inconcistency between security-config_5_0.xsd and xml tests

[aloubyansky]

The problem is in the authentication-jaspi element which is declared in the XSD as

 <xsd:element name="authentication-jaspi">
 <xsd:annotation>
 <xsd:appinfo>
 <jbxb:skip/>
 </xsd:appinfo>
 </xsd:annotation>
 <xsd:complexType>
 <xsd:choice >
 <xsd:element maxOccurs="unbounded" ref="jbsx:login-module-stack"/>
 <xsd:element maxOccurs="unbounded" ref="jbsx:auth-module"/>
 </xsd:choice>
 </xsd:complexType>
 </xsd:element>

The XML tested is

 <jbsx:application-policy name="conf-jaspi">
 <jbsx:authentication-jaspi>
 <jbsx:login-module-stack name="lm-stack">
 <jbsx:login-module
 code="org.jboss.security.auth.spi.UsersRolesLoginModule"
 flag="required">
 <jbsx:module-option name="usersProperties">props/jbossws-users.properties</jbsx:module-option>
 <jbsx:module-option name="rolesProperties">props/jbossws-roles.properties</jbsx:module-option>
 <jbsx:module-option name="unauthenticatedIdentity">anonymous</jbsx:module-option>
 </jbsx:login-module>
 </jbsx:login-module-stack>
 <jbsx:auth-module code="auth.module1.class.name">
 <jbsx:module-option name="usersProperties">props/jbossws-users.properties</jbsx:module-option>
 <jbsx:module-option name="rolesProperties">props/jbossws-roles.properties</jbsx:module-option>
 <jbsx:module-option name="unauthenticatedIdentity">anonymous</jbsx:module-option>
 </jbsx:auth-module>

 <jbsx:auth-module code="auth.module2.class.name" login-module-stack-ref="lm-stack"/>
 </jbsx:authentication-jaspi>
 </jbsx:application-policy>

There can be either auth-module or login-module-stack but not both.

Actually the test currently passes. Though, the SAX parser's validation is supposed to be on. I'll look into that.

Current SchemaBinding-based validation doesn't catch it. I was working on a fix for another issue and extended SchemaBinding validation to catch that.

[anil.saldhana]

Alex. This schema was designed long ago. Once you ensure that the tests fail, I will update the schema to a more correct state.

[aloubyansky]

The test doesn't fail because of entity resolution. If it's fixed like

alex@ASTUDIO /cygdrive/e/cvsroot/jboss-head/testsuite/src/main/org/jboss/test/xml
$ cvs diff DynamicLoginConfigUnitTestCase.java
Enter passphrase for key '/home/alex/.ssh/identity':
Index: DynamicLoginConfigUnitTestCase.java
===================================================================
RCS file: /cvsroot/jboss/jbosstest/src/main/org/jboss/test/xml/DynamicLoginConfigUnitTestCase.java,v
retrieving revision 1.7
diff -r1.7 DynamicLoginConfigUnitTestCase.java
129c129,132
< return null;
---
> int slash = systemId.lastIndexOf('/');
> String shortId = slash == -1 ? systemId : systemId.substring(slash + 1);
> systemId = url.toExternalForm() + shortId;
> return new InputSource(systemId);

then the test will fail.

It's not committed yet. I need to checkout the codebase from the SVN.

[aloubyansky]

And also this feature is missing:

unmarshaller.setFeature(Unmarshaller.SCHEMA_VALIDATION, true);