JBAS-7049: AccessController permission check throwing NPE

[anil.saldhana]

Looks like an OpenJDK6 issue where the permission check for getParent of a classloader is failing with an NPE because probably the parent class loader is null (boot CL).

14:40:13,679 ERROR [AbstractKernelController] Error installing to Described: name=deployers-classloader:0.0.0$MODULE state=PreInstall
java.lang.NullPointerException
 at java.security.AccessControlContext.checkPermission(AccessControlContext.java:330)
 at java.security.AccessController.checkPermission(AccessController.java:553)
 at java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
 at java.lang.ClassLoader.getParent(ClassLoader.java:1241)
 at org.jboss.aop.asintegration.jboss5.SecurityActions$GetParentAction$2$1.run(SecurityActions.java:57)
 at org.jboss.aop.asintegration.jboss5.SecurityActions$GetParentAction$2$1.run(SecurityActions.java:55)
 at java.security.AccessController.doPrivileged(Native Method)
 at org.jboss.aop.asintegration.jboss5.SecurityActions$GetParentAction$2.getParent(SecurityActions.java:53)
 at org.jboss.aop.asintegration.jboss5.SecurityActions.getParent(SecurityActions.java:77)
 at org.jboss.aop.asintegration.jboss5.VFSClassLoaderDomainRegistry.getClassLoaderDomainForLoader(VFSClassLoaderDomainRegistry.java:181)
 at org.jboss.aop.asintegration.jboss5.VFSClassLoaderDomainRegistry.getRegisteredDomain(VFSClassLoaderDomainRegistry.java:165)
 at org.jboss.aop.asintegration.jboss5.VFSClassLoaderScopingPolicy.getDomain(VFSClassLoaderScopingPolicy.java:68)
 at org.jboss.aop.AspectManager.instance(AspectManager.java:248)
 at org.jboss.aop.AspectManager.instance(AspectManager.java:234)
 at org.jboss.aop.microcontainer.beans.AspectManagerFactory.getAspectManager(AspectManagerFactory.java:46)
 at org.jboss.aop.microcontainer.integration.AOPDependencyBuilder.getDependencies(AOPDependencyBuilder.java:102)

Any second thoughts?

This is only on openjdk6 and not on Sun JDK6.

[anil.saldhana]

OpenJDK6 line 330 of AccessControlContext:

if (!dumpDebug) {
 debug.println("access denied " + perm);
 }

OpenJDK7:

 if (dumpDebug) {
 debug.println("access denied " + perm);
}

So definitely this got fixed in openjdk7.

[anil.saldhana]

Thanks to DML.

Actually the openjdk7 code is:

 for (int i=0; i< context.length; i++) {
 if (context != null && !context.implies(perm)) {
 if (dumpDebug) {
 debug.println("access denied " + perm);
 }
 if (Debug.isOn("failure") && debug != null) {
 // Want to make sure this is always displayed for failure,
 // but do not want to display again if already displayed
 // above.
 if (!dumpDebug) {
 debug.println("access denied " + perm);
 }
 Thread.currentThread().dumpStack();
 final ProtectionDomain pd = context;
 final Debug db = debug;
 AccessController.doPrivileged (new PrivilegedAction<Void>() {
 public Void run() {
 db.println("domain that failed "+pd);
 return null;
 }
 });
 }
 throw new AccessControlException("access denied "+perm, perm);
 }
 }

Looks like the debug != null check has been added on the if condition in openjdk7.

[anil.saldhana]

DML created a bug : http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=364