[hbarlas]

This post is regarding the IP Address parameterization in the JBoss testsuite. I will go over the idea again of what is being accomplished. Basically by allowing parameterization of the testsuite it will be possible to run the testsuite on an IP other than the current hardcoded 'localhost'. Below is a summary of what changes were made to the testsuite, their impact and comparisons between the unmodified testsuite and the 'parameterized' testsuite.

======================
DESCRIPTION OF CHANGES
======================

----------
Filtersets
----------
1) Filtersets were applied in the "compile-resources" target to parameterize all .xml, .properties and .wsdl files.

2) In imports/code-generation.xml the "init-code-generation" target now depends on the "compile-resources" target.
This is needed because the token substitution is performed in the "compile-resources" target. It must be called
before code-generation starts to allow the proper IP to be propagated in build/resources.

3) In imports/test-jars.xml all occurences of {source.resources} have been replaced by {build.resources}.
The "compile-resources" target ensures that the @NODE_0@ token in src/resources is substituted correctly with the IP to form build/resources. Therefore test-jars.xml must reference {build.resources} instead of {source.resources}

---------------------
Property Substitution
---------------------
1) In all the jboss-client.xml files, localhost is replaced with the property {jboss.bind.address}.


2) Occurrences of localhost in the source code in src/main have been parameterized as follows:
- all the testcase source files use getServerHost()
- static variables and methods use System.getProperty("jbosstest.server.host" , "localhost")
- server related code uses System.getProperty("jboss.bind.address" , "localhost")


============
IMPACT
============

There won't be any difference in using the testsuite, it will output the same results as the current one.
When used with a specified IP on non-clustered tests, it will run exclusively on that IP. Since these are big changes to the testsuite, my suggestion is to tag the existing testsuite as 'pre-parameterized'.

[adrian.brock]

We need to revert JBAS-1864. This is a step backwards.
The keyword is *incremental* builds.

Parameterization should be at runtime.
I don't want to have to rebuild the testsuite to change the host I want to run tests against.

I also eventually want a modular/declarative/incremental testsuite build that I can run
from inside JBoss/IDE on an embedded JBoss server.

What is the issue with the system properties? They should be accepted in all deployments.
If the problem is that the server uses a different a system property (jboss.bind.address)
to the testsuite (jboss.test.serverhost, nodeN.xxx.yyy) then we need to address this.