-
1. Re: Test suite classpath normalization
starksm64 Jan 15, 2007 11:31 PM (in response to ryan.campbell)This is needed, but we should be building more test group specific client classpaths to better track what tests require what jars from the client dir.
Note that some tests do rely on server jars at they try to tests implementation details. These tests should be moved into the corresponding module they are testing the implementation of.
We are starting to include more tests in modules, so we need a way to run these tests as part of the overall qa tests. -
2. Re: Test suite classpath normalization
ryan.campbell Jan 15, 2007 11:50 PM (in response to ryan.campbell)Ok, so it sounds like you want something like several of these:
<test-target>.classpath
where <test-target>.classpath is the ant target with dashes converted to dots. So we would have:
jboss.all.config.tests.classpath
tests.security.manager.classpath
tomcat.ssl.tests.classpath
etc...
We will come up with estimates for the monolithic test classpath vs. group level classpaths. The monolithic test classpath will meet our immediate needs, but I realize the group level classpaths provide better documentation and better analysis of depdencies.
Good point on the server jars, they could be included from ${jboss.dist} as well.
As for the tests in other modules, this goes back to isolating the test harness/refactoring the test suite. This is in scope for the near future, but I'd like to keep that discussion separate. -
3. Re: Test suite classpath normalization
starksm64 Jan 16, 2007 12:08 AM (in response to ryan.campbell)"ryan.campbell@jboss.com" wrote:
Ok, so it sounds like you want something like several of these:
<test-target>.classpath
where <test-target>.classpath is the ant target with dashes converted to dots. So we would have:
jboss.all.config.tests.classpath
tests.security.manager.classpath
tomcat.ssl.tests.classpath
etc...
We will come up with estimates for the monolithic test classpath vs. group level classpaths. The monolithic test classpath will meet our immediate needs, but I realize the group level classpaths provide better documentation and better analysis of depdencies.
Sounds good."ryan.campbell@jboss.com" wrote:
As for the tests in other modules, this goes back to isolating the test harness/refactoring the test suite. This is in scope for the near future, but I'd like to keep that discussion separate.
Ok. -
4. Re: Test suite classpath normalization
pavel.tsekov Jan 16, 2007 9:54 AM (in response to ryan.campbell)Are there any tests in the testsuite that require .jar libraries from ${jboss.dist}/client ?
-
5. Re: Test suite classpath normalization
starksm64 Jan 16, 2007 1:33 PM (in response to ryan.campbell)Not currently as the testsuite classpath is built from the jbossas module classpaths.
-
6. Re: Test suite classpath normalization
ryan.campbell Jan 16, 2007 2:00 PM (in response to ryan.campbell)Right, so instead of building the classpath from jbossas module classpaths, we want to build it primarily from ${jboss.dist}/client. All tests will then require .jar libraries from ${jboss.dist}/client.
-
7. Re: Test suite classpath normalization
mvecera Mar 10, 2007 3:48 PM (in response to ryan.campbell)Hello,
I have an idea I would like to discuss here. I copied tests.classpath to tests.compile.classpath. Then I added all jar files in build/output/JBoss-xxx/client/ at the beginning of test.classpath.
Now using tests.compile.classpath for compiling tests and tests.classpath for running tests should result in desired behavior, shouldn't it?
Because java searches for the first location of class in classpath it should use maximum of client/*.jar files.
Is this correct? -
8. Re: Test suite classpath normalization
starksm64 Mar 10, 2007 8:27 PM (in response to ryan.campbell)Yes, that is correct.
-
9. Re: Test suite classpath normalization
ryan.campbell Mar 12, 2007 10:07 PM (in response to ryan.campbell)The patch on the http://jira.jboss.com/jira/browse/JBAS-3993 looks good to me and should be applied to all branches:
Branch_3_2
Branch_4_0
Branch_4_2
/trunk