Testsuite broken in 4.2

[adrian.brock]

The testsuite build for 4.2 is broken.

[ejort@warjort testsuite]$ ./build.sh
Searching for build.xml ...
Buildfile: /home/ejort/jboss-4.2/testsuite/build.xml
<snipped/>
_jars-classloader:
 [jar] Building jar: /home/ejort/jboss-4.2/testsuite/output/lib/java-sql.jar
 [unzip] Expanding: /home/ejort/jboss-4.2/testsuite/output/lib/loading.sar into /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource1.ear/loading.sar
 [copy] Copying 1 file to /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource1.ear/loading.sar/META-INF
 [mkdir] Created dir: /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource2.ear/loading.tmp/META-INF
 [unzip] Expanding: /home/ejort/jboss-4.2/testsuite/output/lib/loading.sar into /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource2.ear/loading.tmp
 [copy] Copying 1 file to /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource2.ear/loading.tmp/META-INF
 [copy] Copying 2 files to /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource2.ear/loading.tmp/dtds
 [copy] Copying 1 file to /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource2.ear/loading.tmp/dtds
 [zip] Building zip: /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource2.ear/loading.sar
 [delete] Deleting directory /home/ejort/jboss-4.2/testsuite/output/lib/unpacked/loadingresource2.ear/loading.tmp
 [copy] Copying 1 file to /home/ejort/jboss-4.2/testsuite/output/gen-src/org/jboss/test/classloader/scoping/singleton
 [echo] V1 MySingleton.java cksum: 4208e590356f488b8d8ab24a93c292a5
 [copy] Copying 1 file to /home/ejort/jboss-4.2/testsuite/output/classes/org/jboss/test/classloader/scoping/singleton
 [javac] Compiling 1 source file to /home/ejort/jboss-4.2/testsuite/output/classes

BUILD FAILED
/home/ejort/jboss-4.2/testsuite/imports/sections/classloader.xml:230: /home/ejort/jboss-4.2/testsuite/${jboss.dist}/client not found.

The following diff fixes it:

[ejort@warjort testsuite]$ svn diff
Index: build.xml
===================================================================
--- build.xml (revision 61436)
+++ build.xml (working copy)
@@ -239,6 +239,9 @@
 <path refid="thirdparty.classpath"/>
 </path>

+ <!-- Import the jboss server run targets -->
+ <import file="imports/server-config.xml"/>
+
 <!-- Classpath to run the tests -->
 <path id="tests.classpath">
 <fileset dir="${jboss.dist}/client">
@@ -426,8 +429,6 @@
 <!-- Import the test jars build targets -->
 <import file="imports/test-jars.xml"/>

- <!-- Import the jboss server run targets -->
- <import file="imports/server-config.xml"/>
 <!-- Propagate the dist directory as a jbosstest system property -->
 <property name="jbosstest.dist" value="${jboss.dist}"/>

Not sure how this worked for whoever made the change?

I thought we still used the buildmagic property implementation that did
lazy property evaluation, or was that supposed to have been rolled into ant?

[mvecera]

Hello,
I was applying patch concerning JBAS-3993, but suddenly the ${jboss.dist} is unknown in build.xml. I commented it out, so now it works.

[anil.saldhana]

This is broken in trunk. Can you please comment out dist setting in build.xml of trunk?

I have commented it out and checked in.

Also can you check your editor settings? There way too many spaces (maybe tabs) between the lines for this dist setting.

Use spaces instead of tabs.

[ryan.campbell]

Fixed in 4.2:

Committed revision 61478.

[ryan.campbell]

Fixed in /trunk.

I tested a clean compile works.