cglib,asm not available in client dir

[thomas.diesler]

Scott,

IMHO it is nonsense that cglib.jar + asm.jar are not deployed in jboss-4.0.4.GA/client

This forces the

- wstools scripts
- standalone jbossws samples
- CTS configuration

to pull in these jars (that a jbossws client needs) from some server configuration. This also causes a dependency on a particular server config name.

I suggest we deploy cglib.jar + asm.jar in jboss-4.0.4.GA/client and remove the dependency on those jars in jbossws-1.0.1.

cheers
-thomas

[starksm64]

And my view is that this dependency should never have crept in. javassist is the dominate bytecode maninpulation framework and hibernate upated to support it. If anything, jbossws-1.0.0 needs to be delayed until this dependency is removed in favor of the already existing javassist dependency.

[thomas.diesler]

Ok, that can be done.

 <path id="client.classpath">
 <fileset dir="${jboss.home}/client">
 <include name="jbossall-client.jar"/>
 <include name="jbossws14-client.jar"/>
 <include name="jbossws-client.jar"/>
 <include name="commons-logging.jar"/>
 <include name="jboss-backport-concurrent.jar"/>
 <include name="jbossretro-rt.jar"/>
 <include name="activation.jar"/>
 <include name="log4j.jar"/>
 <include name="mail.jar"/>
 </fileset>
 <fileset dir="${jboss.home}/server/${jboss.server}/lib" includes="cglib-*.jar">
 <include name="asm.jar"/>
 </fileset>
 </path>

Can we move these to jbossall-client.jar

 <include name="commons-logging.jar"/>
 <include name="jboss-backport-concurrent.jar"/>
 <include name="jbossretro-rt.jar"/>

[thomas.diesler]

Remove dependency on cglib
http://jira.jboss.com/jira/browse/JBWS-842

[thomas.diesler]

commons-logging should probably not be in jbossall-client.jar, but how about the jbossretro jars?

[starksm64]

This would make jbossall-client.jar dependent on javassist and since we include jbossall-client.jar both the java5/java1.4.x profiles, we would have to include javassist in both. I suppose that is not a problem and that eventually we would need javassist for ejb3/aop on the client container anyway.

[jason.greene]

This is done.

[thomas.diesler]

Currently jboss-backport-concurrent.jar and concurrent.jar cannot be included in jbossall-client.jar at the same time, because when unzipping the jars there is no difference between 'EDU' and 'edu' on a WinXP system.

I suggest concurrent.jar should be backported to org.jboss.edu....

[ryan.campbell]

Could we use zipfilesets to aggregate the jars instead? This would make the build more incremental by getting rid of the delete/unjar/jar process and just have one jar task with zipfilesets for each jar file. Unless we are doing it this way for some reason.

This way we wouldn't have to rename the package, and the build would go faster.