JBWS-1260 - Sequence containing 2 elements

[dlofthouse]

Taking the following two elements as the input and ouput parameters: -

<element name='lookup'>
 <complexType>
 <sequence>
 <element name='firstName' nillable='true' type='string'/>
 <element name='surname' nillable='true' type='string'/>
 </sequence>
 </complexType>
 </element>

 <element name='lookupResponse'>
 <complexType>
 <sequence>
 <element name='areaCode' nillable='true' type='string'/>
 <element name='number' nillable='true' type='string'/>
 </sequence>
 </complexType>
 </element>

wscompile is generating the SEI method as: -

public org.jboss.test.ws.jbws1260.LookupResponse lookup(java.lang.String firstName, java.lang.String surname) throws java.rmi.RemoteException;

So the input element is being unwrapped as it can be converted to seperate parameters, however the return type can not be unwrapped so it is not.

The JAX-RPC 1.1 specification doesn't seem to say how this should be handled. Previously we were dropping the second element in the return type and would just return a String.

Tha JAX-WS spec seems to clarify this by mapping the wrapper children as a parameter using a holder type.

Which approach should we be taking, especially as we don't currently generate holders?

[jason.greene]

The partial wrapping wscompile does in this situation is wrong. We have two options, either generate holders, or fallback to bare style. The former would be dependent on the code changes I am currently merging into the 1.0 branch, the latter would save time. So I leave it up to you.

[dlofthouse]

To get this task finished I will probably fall back to bare style. At the point of this Jira issue (and all the other issues being raised) we have no support for generating holders.

I will have a look at what you have so far for holders and will create a new task to add support for unwrapping using holders if needed.

[dlofthouse]

We can use the holders for standard types but I think it will be easier to get full support for holders in a single task without adding it to this task.

[jason.greene]

Agreed

[dlofthouse]

Related to the partial unwrapping wscompile was doing what should we do if any of the message parts reference an element that is a simple type?

e.g.

<s:element name="string" nillable="true" type="s:string" />

At the moment if the element references anything other than a complex type we reject the WSDL.

[jason.greene]

Right, a simple type is not a valid wrapper type, so if it is used only the bare parameter style can be used.