@WebServiceRef default name

[asoldano]

This is related to http://jira.jboss.com/jira/browse/JBMETA-64.

Well, considering the api doc says the default name should be as is now in trunk, I was thinking it's probably better to close the issue as "won't fix" (thus changing the behavior we had in Beta4). On my side I would have changed the tests, in order not to use the default name (i.e. I'll always use the name attribute) to pass on both containers. My only concern now is that the old naming default was probably used to cope with cases of multiple class having different attribute annotated with @WebServiceRef with the same name:

...
public class A
{
@WebServiceRef
private ServiceOne prettyService;
...
}


...
public class B
{
@WebServiceRef
private ServiceTwo prettyService;
...
}


What do you think about this Emanuel?

[emuckenhuber]

Hmm yes, as the serviceRefName is used for jndi binding this could lead to a conflict.
I mean i think decalaringClass / name makes more sense and would avoid this. And as you mentioned that the spec is unclear on this, we maybe should use the default naming like it was in beta4!?

[asoldano]

"emuckenhuber" wrote:
Hmm yes, as the serviceRefName is used for jndi binding this could lead to a conflict.
I mean i think decalaringClass / name makes more sense and would avoid this. And as you mentioned that the spec is unclear on this, we maybe should use the default naming like it was in beta4!?

OK, that's fine with me (using the default name declaringClass / name).

[emuckenhuber]

okay i changed that.

Additionally it is not allowed anymore to define a @WebServiceRef on a Type without specifying the name attribute - as they say:
'For class annotations, there is no default and this must be specified.'

So i think this is ok too ? :)

[asoldano]

OK, I'll give it a try. And, yes, I think it's ok to require the name for @WebServiceRef on a type.
Thank you

[asoldano]

Fix working properly, I've tested it creating a local snapshot of the metadata prj. Waiting the metadata release to solve the issues depending on JBMETA-64.
Thanks