XML Comments in JGroups config of tc5-cluster.sar

[stuart_wildcat]

I notice that recently the default UDP configuration of the tc5-cluster.sar\META-INF\jboss-service.xml file has been changed along with the location of the configuration from the previous tc5-cluster-service.xml file.

My concern is that there are XML comments inside of the UDP configuration which make it impossible to simply comment out the default UDP configuration and uncomment the alternate TCP configuration.

Because of this embedded commenting any attempt to place comments around the outside of the default UDP tag fail because the end tag of the embedded comment is encountered and you end up with the last few lines of the UDP configuration being considered "outside" the comment.

It would be ideal to be able to simply switch between these configurations by placing a few external comments but preserve the configuration for use later.

The lines I am referring to are:

 <pbcast.GMS print_local_addr="true" join_timeout="3000"
 down_thread="false" up_thread="false"
 join_retry_timeout="2000" shun="true"/>
 <!-- If your CacheMode is set to REPL_SYNC we recommend you
 comment out the FC (flow control) protocol -->
 <FC max_credits="10000000" down_thread="false" up_thread="false"
 min_threshold="0.20"/>
 <FRAG2 frag_size="60000" down_thread="false" up_thread="false"/>
 <pbcast.STATE_TRANSFER down_thread="false" up_thread="false"/>
 </config>

[brian.stansberry]

Good point. I'll move the comment.

[stuart_wildcat]

Thanks so much. I would just hate to lose all of that great UDP tuning that has been added.

Although I agree that UDP makes JBoss Clustering MUCH easier I'm thinking of clients that might have network policies which disable or restrict UDP for whatever reason.

On another note, is there any discussion or possibility of moving the JGroups configuration which is currently in two separate files into one location? I know it might be an issue with classloading or the maintainence of the Tomcat package overall but it seems like it would be easier to manage large cluster configurations if this were in one location. I would imagine most JBoss environments end up configuring JGroups the same way in both locations.

[brian.stansberry]

JGroups 2.3 introduces the Multiplexer, which allows multiple services to multiplex on top of a single JGroups channel. In AS 5.0, the various clustering services will by default all run on a single multiplexed channel.

Even if you wanted separate channels, the protocol stack configurations for the channels will all reside in one place.

Due to backward compatibility restrictions, this kind of setup will not be the default in any 4.0.x release, although we are looking at making it an installer option.

[stuart_wildcat]

Sounds great! Yet another feature I can't wait to see in v5!