This content has been marked as final.
Show 11 replies
-
1. Re: block specific customizations
julien1 Jan 18, 2004 5:32 AM (in response to jae77)"cooper" wrote:
do you mean JMX console or in the block module ? -
2. Re: block specific customizations
jae77 Jan 18, 2004 10:17 AM (in response to jae77)"jae77" wrote:
in the block module itself. -
3. Re: block specific customizations
jae77 Jan 19, 2004 12:38 PM (in response to jae77)"jae77" wrote:
so - after digging around in the code, it appears that the BlockModule attempts to invoke a method called "edit" on the block itself, which means i should just have to provide an implementation of the edit method.
however, the BlockSupport class declares that method to be final. is this just a small oversight, or was it planned this way? -
4. Re: block specific customizations
julien1 Jan 19, 2004 12:44 PM (in response to jae77)"cooper" wrote:
planed of course, if can change to be not final if you need that. -
5. Re: block specific customizations
jae77 Jan 19, 2004 1:30 PM (in response to jae77)"jae77" wrote:
well - did you have another implementation idea in mind, or was it intended for blocks that wanted to expose more information about themselves to do so in another manner? -
6. Re: block specific customizations
julien1 Jan 19, 2004 1:34 PM (in response to jae77)"cooper" wrote:
each block is supposed to be able to display a custom control panel but I never found the time to work on it. -
7. Re: block specific customizations
jae77 Jan 19, 2004 3:24 PM (in response to jae77)"jae77" wrote:
ok - well - i'd like to help out w/ this.
off the cuff, i'm thinking that the BlockSupport module could provide an abstract (or stubbed) protected method that anyone who wants custom controls could implement.
this could allow the edit method's signature to remain unchanged and prevent any misuse.
thoughts? if you had something else in mind just let me know the details and i'll investigate. -
8. Re: block specific customizations
julien1 Jan 19, 2004 4:56 PM (in response to jae77)"cooper" wrote:
this is the goal of the edit method that does nothing by default. I change it to :public void edit(Page page) { ... }
-
9. Re: block specific customizations
julien1 Jan 19, 2004 4:58 PM (in response to jae77)"cooper" wrote:
note that there is the method update(Page page) that should cooperate with the edit method to update the changes proposed by the edit(Page page) method -
10. Re: block specific customizations
jae77 Jan 19, 2004 6:11 PM (in response to jae77)"jae77" wrote:
"jae77" wrote:
ok - thx. i'll let you know if i have any problems. -
11. Re: block specific customizations
julien1 Jan 19, 2004 6:13 PM (in response to jae77)"cooper" wrote:
"cooper" wrote:
I have commited the changes in the CVS, should be visible later for you when public CVS will be updated