Updated downloads module

[chasetec]

Well I started off forking the downloads module in to a links/bookmark module and I discovered some problems with the download module along the way so I decided to fix those fist.

I found one repeatable way to cause an Exception and a module operation that was linked to in one of the views that was never implemented. I'm guessing it just wasn't ever finished off......

At some point I'd like to get cvs access to add my links module which should hopefully be done this week but in the mean time what do I do with my updates to the download module? Should I post bug reports over on SF for the problems I found still?

I still haven't changed any version numbers in any of the files yet and I'd like some comments on what I've done since I just started playing with Nukes modules last week. You can get my work in progress at http://www.ej4l.com/downloads.zip.

[julien1]

what do you want to do ? fix the download module bugs and submit new code ?

[chasetec]

Guess I should mention what I did for those that don't want to do a diff and figure it out.

Fixed a repeatable exception which can be caused by the following:
Go to the details for a download without an editorial, click Editor review.

The un-implemented method link was reachable by clicking on "comments" for a download with comments and then clicking on the little edit graphic. I added in all the needed methods to the module and stuff to the template and resouce file so that an admin can modify any rating/comment. I also made it so that the edit graphic link only appears for admins.

[chasetec]

what do you want to do ? fix the download module bugs and submit new code ?

yep

[theute]

I will look at the diff and come back to you if needed, i have right access in the CVS and may submit code in your name.

Usually the process is to submit patches first then you get CVS access.

Thanks for your help !

[theute]

Good job,
i looked at the diff and made the changes in my 1.1 sandbox, it works great.
I hope you will get R/W access to the CVS soon.

All your new features should go in HEAD, and all your bug fixes in HEAD and 1.1.

I will commit the bug fixes in 1.1 and in HEAD for you as i'd like to finish packaging 1.1 ASAP.

Thanks for your great work. I hope you will be able to improve that module and maybe some others :)

[chasetec]

Based on what was mentioned over at http://www.jboss.org/index.html?module=bb&op=viewtopic&t=53145 I found another bug(s).

My new update to the downloads modules is at http://www.ej4l.com/downloads.zip
If someone else could try it out that'd be great.

Things fixed/changed in this update:
1) Entering a ftp url causes a ClassCastException
2) Support was added to validate ftp urls
3) Support was added to allow ftp style urls with usernames and passwords

[chasetec]

All updates to the downloads module are now in CVS so I'm removing the zip of my updates. Here's the log of the latest CVS update:

Implemented minor wording and layout changes.

Minor features added to fix bugs:

* Support was added to validate ftp urls
* Support was added to allow ftp style urls with usernames and passwords

Bugs fixed:

* Entering a ftp url causes a ClassCastException
* Deleting a rating(along with it's comment) doesn't recalculate the total
number of comments
* Deleting a rating doesn't recalculate the overall rating of a download
* A user creating or modifying their rating of a download to "--" will cause
an ArrayIndexOutOfBoundsException if they view the details for that download
* A user modifying their comment to nothing doesn't cause the total number of
comments to be updated for that download
* A user could rate a download to any number by typing in the correct url
* A user rating a comment to something other then 1 through 10 is sent back to
the main download page with no error message
* After an admin accepts or ignores the last download modification request,
presses "Return to modification rerquests" and then "Back" an error is displayed
* The "File link" portion of a users modification request is ignored if approved
* The admin's modification request page doesn't display the "File link" information
* The "Main Download Area" button was not display on the admin's modification
request page when there was no request
* The page layout was wrong when the admin had more then one download modification
request to view

[julien1]

impressive number of bug fixes.

[chasetec]

Guess I was just happy to get commit rights :)

[thepriz]

Wow, I guess two pairs of eyes are better than one.

Thanks for doing the ftp validation was going to get to that but never had the chance. I got really busy at work.