BBModule, 1.1.0-RC3

[marndt]

Hi.
I do not know whether there is a bug tracking system set up for nukes, so I post the bug here:

BBModule.java, Revision: 1.67.2.3, line # 2882:

if (posterIcq == null && posterIcq.length() > 0)

since the default values ' ' are set to NULL in Oracle the code breaks here.

[julien1]

what kind ? be more expicit please.
I did not try 3.2RC2, I will soon.

julien

[julien1]

As far a some of what I've done:

Some is layout control, for instance: when viewing any topic my system(1024x768 resolution) renders the topic's center column too wide. The primary thing throwing the layout of(even on jboss.org) are the Quick Reply and the Jump to being too wide to be in the same row. Same with the little bb image headers when a user is logged in and using certain layouts.

I've fixed some of the security checks. If I remember correctly(late night coding) if you set a Forum's Reply and Post permissions to REG and then an annonymous use tried to do either of those things then stuff blew up.

The permission messages being displayed weren't correct when the security checks failed, now it's something like "I'm sorry but you must be at least an administrator to post messages in this forum" but before some TODO text was getting displayed and in one place a PHP sprintf was being displayed as an error message.


As far as what I want to do, I want to strip every half-way feature that's not going to be implemented before 1.1 release and fix all the security checking and moderation functionality. Things are happening like at the bottom of the page a message being displayed is "You can delete your posts in this forum" except unless I've made the person a mod then they can't! There seem to be security permission for features like attachments that aren't in the 1.1 branch. Basically I want the BB users to be able to view, modify, delete their posts; have many different mods managing forums with different permissions and have everyone be able to do everything at 1024x768(at minimum) with nothing being pushed off the screen except maybe in the \[code\] sections...

Isn't the "Disable BBCode in this post" suppossed to make the \[code\] statement's appears as typed and not rendered in any special way?

[julien1]

should not it be : portletIcq != null && posterIcq.length() > 0 ?

"marndt" wrote:
Hi.
I do not know whether there is a bug tracking system set up for nukes, so I post the bug here:

BBModule.java, Revision: 1.67.2.3, line # 2882:

if (posterIcq == null && posterIcq.length() > 0)

since the default values ' ' are set to NULL in Oracle the code breaks here.

[marndt]

Sure. I submitted a bug, not a solution :-)
This is not the only place where the code breaks. You should probably start setting up an Oracle distribution and you will find all the NPE-places quite fast!
Regards,
Michael

[theute]

I fixed that bug.
Where are the other places where the code break that you are talking about ?

Thanks.

[chasetec]

Are the auto pruning and locking features going to be finished before 1.1 is released? If the code stays commented out the html should get commented out also.

Underneath the "Who is Online" section I'm seeing ${bb.Posted_articles_total} displayed.

[chasetec]

Is there an active appointed lead developer for the BB module? I've fixed some errors but some things like the moderation funtionality and control panel need a decent amount of work....I can look at it over the next week but I don't want to step on anyone elses toes. All dealing with 1.1 here.

[julien1]

I take care of that module (which does not mean that nobody else cannot work on it).

Could you describe modifications you have done and you plan to do ?

What is the decent amount of work here ?

[chasetec]

As far a some of what I've done:

Some is layout control, for instance: when viewing any topic my system(1024x768 resolution) renders the topic's center column too wide. The primary thing throwing the layout of(even on jboss.org) are the Quick Reply and the Jump to being too wide to be in the same row. Same with the little bb image headers when a user is logged in and using certain layouts.

I've fixed some of the security checks. If I remember correctly(late night coding) if you set a Forum's Reply and Post permissions to REG and then an annonymous use tried to do either of those things then stuff blew up.

The permission messages being displayed weren't correct when the security checks failed, now it's something like "I'm sorry but you must be at least an administrator to post messages in this forum" but before some TODO text was getting displayed and in one place a PHP sprintf was being displayed as an error message.


As far as what I want to do, I want to strip every half-way feature that's not going to be implemented before 1.1 release and fix all the security checking and moderation functionality. Things are happening like at the bottom of the page a message being displayed is "You can delete your posts in this forum" except unless I've made the person a mod then they can't! There seem to be security permission for features like attachments that aren't in the 1.1 branch. Basically I want the BB users to be able to view, modify, delete their posts; have many different mods managing forums with different permissions and have everyone be able to do everything at 1024x768(at minimum) with nothing being pushed off the screen except maybe in the \[code\] sections...

Isn't the "Disable BBCode in this post" suppossed to make the \[code\] statement's appears as typed and not rendered in any special way?

[jae77]

"chasetec" wrote:


As far as what I want to do, I want to strip every half-way feature that's not going to be implemented before 1.1

given that the 1.1 release is at RC3 and very close to being final, i would doing this consider this a large risk for 1.1 and would push back on having it included. overall, however, i think this is a great idea and would help move the forums to being more robust and usable.

[jae77]

"chasetec" wrote:

Isn't the "Disable BBCode in this post" suppossed to make the \[code\] statement's appears as typed and not rendered in any special way?

i believe that applies to all tags availble, ie: [ b ] , [ i ], etc.

i would not recommend (or perhaps this could be configurable) to disable the "code" block even if the checkbox is enabled - at least on these forums. lots of ppl post code/xml snippets, etc and posts would become useless pretty quickly if that didn't render correctly.

[julien1]

I agree, only cosmetics should be done.

Please keep in mind that the modules are going to be ported to nukes 2 in the next 3 months are 1.1 wold probably be the last release.

[julien1]

agree again

[chasetec]

I'll look this weekend and see which features would be easiest to finish and which ones would be easiest to strip/comment out and post a list to get everyones opinion.

Is Nukes 1.1 going to be completely dropped the minute version 2 comes out? If so what's the point in HEAD? Are we going to be porting from HEAD or 1.1? Is 2 going to support the Nukes 1.1 modules or how much are things going to be different?