Portability issue in BB module table defn phpbb_attachments_

[mlavergn]

To keep it brief, the table phpbb_attachments_desc, which is currently only in cvs heads' bb module, contains a column named "comment" which is a reserved word in Oracle. There is no painless workaround for this restriction so I would like to rename that column from "comment" to "comments". At a minimum this would only affect the setup.xml and AttachmentEJB.java files while being transparent to everything else. However, if we want to avoid any potential "where did that 's' come from" scenarios, we would need to also change Attachment.java, the language prop files, and some tpl files. Personally, I'd just like to change pluralize underlying column name and keep things simple. Thoughts, concerns, suggestions?

[julien1]

I found this in my log:

2004-09-23 10:07:34,083 INFO [org.jboss.deployment.MainDeployer] Starting deployment of package: file:/C:/projects/DataDistribution/DataDistribution/ddBuild/output/jboss-3.2.3/server/default/nukes/nukes-jmx.sar
2004-09-23 10:07:34,123 ERROR [org.jboss.nukes.system.JDBCPersistenceManager] Cannot sync attribute
org.jboss.nukes.utils.ConversionException: A property editor has not been found for type java.util.Map
 at org.jboss.nukes.utils.Tools.findEditor(Tools.java:782)
 at org.jboss.nukes.utils.Tools.fromObject(Tools.java:836)
 at org.jboss.nukes.system.JDBCPersistenceManager.syncAttribute(JDBCPersistenceManager.java:102)
 at org.jboss.nukes.system.JDBCPersistenceManager.load(JDBCPersistenceManager.java:289)
 at org.jboss.nukes.system.JDBCPersistenceManager.load(JDBCPersistenceManager.java:320)
 at org.jboss.mx.modelmbean.ModelMBeanInvoker.load(ModelMBeanInvoker.java:237)
 at org.jboss.mx.modelmbean.ModelMBeanInvoker.initPersistence(ModelMBeanInvoker.java:413)
 at org.jboss.mx.modelmbean.ModelMBeanInvoker.preRegister(ModelMBeanInvoker.java:294)
 at org.jboss.mx.server.registry.BasicMBeanRegistry.registerMBean(BasicMBeanRegistry.java:148)
 at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:324)
 at org.jboss.mx.capability.ReflectedMBeanDispatcher.invoke(ReflectedMBeanDispatcher.java:284)
 at org.jboss.mx.interceptor.ObjectReferenceInterceptor.invoke(ObjectReferenceInterceptor.java:59)
 at org.jboss.mx.interceptor.MBeanAttributeInterceptor.invoke(MBeanAttributeInterceptor.java:43)
 at org.jboss.mx.interceptor.PersistenceInterceptor2.invoke(PersistenceInterceptor2.java:93)
 at org.jboss.mx.server.MBeanInvoker.invoke(MBeanInvoker.java:76)
 at javax.management.modelmbean.RequiredModelMBean.invoke(RequiredModelMBean.java:144)
 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:546)
 at org.jboss.mx.server.MBeanServerImpl.registerMBean(MBeanServerImpl.java:997)
 at org.jboss.mx.server.MBeanServerImpl.registerMBean(MBeanServerImpl.java:957)
 at org.jboss.mx.server.MBeanServerImpl.createMBean(MBeanServerImpl.java:319)
 at org.jboss.system.ServiceCreator.install(ServiceCreator.java:121)
 at org.jboss.system.ServiceConfigurator.internalInstall(ServiceConfigurator.java:151)
 at org.jboss.system.ServiceConfigurator.install(ServiceConfigurator.java:114)
 at org.jboss.system.ServiceController.install(ServiceController.java:225)
 at sun.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:324)
 at org.jboss.mx.capability.ReflectedMBeanDispatcher.invoke(ReflectedMBeanDispatcher.java:284)
 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:546)
 at org.jboss.mx.util.MBeanProxyExt.invoke(MBeanProxyExt.java:177)
 at $Proxy4.install(Unknown Source)
 at org.jboss.deployment.SARDeployer.create(SARDeployer.java:183)
 at org.jboss.deployment.MainDeployer.create(MainDeployer.java:786)
 at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:641)
 at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:605)
 at sun.reflect.GeneratedMethodAccessor20.invoke(Unknown Source)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:324)
 at org.jboss.mx.capability.ReflectedMBeanDispatcher.invoke(ReflectedMBeanDispatcher.java:284)
 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:546)
 at org.jboss.mx.util.MBeanProxyExt.invoke(MBeanProxyExt.java:177)
 at $Proxy6.deploy(Unknown Source)
 at org.jboss.deployment.scanner.URLDeploymentScanner.deploy(URLDeploymentScanner.java:302)
 at org.jboss.deployment.scanner.URLDeploymentScanner.scan(URLDeploymentScanner.java:476)
 at org.jboss.deployment.scanner.AbstractDeploymentScanner$ScannerThread.doScan(AbstractDeploymentScanner.java:201)
 at org.jboss.deployment.scanner.AbstractDeploymentScanner$ScannerThread.loop(AbstractDeploymentScanner.java:212)
 at org.jboss.deployment.scanner.AbstractDeploymentScanner$ScannerThread.run(AbstractDeploymentScanner.java:191)

Any Ideas?

[theute]

I made the attachment part and didn't think about that issue. Sorry about that.

Well, as there were no release of Nukes using the attachments in forum, i guess you can go ahead and do all the changes you want/need to keep the code simpler. No need of backward compatibility in that case.

People who use the HEAD version are aware that the design can change anytime.

[mlavergn]

Thanks Thomas ... I'll change it to "comments" like I mentioned and get it all checked back in.