BBModule Editing and Deleting & Status list

[chasetec]

I've commited some bug fixes that should enable both user and moderator editing and deleting of messages.

Moderators can edit and delete any message. And for anyone else who had trouble figuring it out, Moderators are configured from the Permissions module and not the Forum Security Module. Users, if granted permissions from the Forum Security Module can delete any post they own as long as it hasn't been replied to and they can edit any of their messages.

The main problem that was keep the existing code from working(but not the only thing) is that isIdentical() doesn't seem to work as expected. Most places in the BBModule where calling this indirectly through EJB.areIdentical(). Apparently the bug has been discovered before(of course I didn't find out till after hunting it down myself). http://www.jboss.org/index.html?module=bb&op=viewtopic&t=51307


Other bug fixes besides the work arounds for isIdentical include:

In BBModule.java - Fixed Edit message, it was "Last edited by Sun Oct 3, 2004 05:22 AM on 2; edited"

In BBModule.java - Added the display of the status message when a poll or message is deleted(was blank info box)

In Context.java - Fixed Poster name not being set

In EditPostCommand.java - Made it so that even moderators affect the time and count of modification

In EditPostCommand.java - Trying to create a poll by modifiy a message is ignored now

In DeletePostCommand.java - Put the code that detects which post is the last in a topic in the right place so users can delete a post as long as it hasen't been replied to.


Other issues that need addressing include:

Shouldn't the defaults for Permissions->bb->Admins be .*:.*: instead of ::

Viewing a Forum shows no moderators "Moderators: None"

An anonymous user adding a poll or message doesn't have their username saved even though there is a field

Would be really nice if the redirect after stuff worked...

Comment out the avatar stuff till it's fully implemented

Setting the vote permissions to all doesn't stay

Permissions page needs to be layed out to fit on the screen.

What is Repost supposed to do? only shows with mod permissions.

The show IP link doesn't work, not sure how much or the Mod Control Panel works...

All the attachement stuff needs to be removed? Would the BB tables stay the same even on the next version of Nukes(should we leave the attachement stuff in the EntityBeans only?)

That url bug still needs to be looked at(http://sourceforge.net/tracker/index.php?func=detail&aid=1020227&group_id=22866&atid=376685)

The Moderators topic splitting doesn't work...


That's all folks!(so far this week anyway)

[julien1]

I have a composite primary key made up of two Integer fields as I was able to create a PK class from the EJB 3.0 example. However my situation is different from the example in that one of the fields of the primary key is the JoinColumn to another table. This causes Jboss (Hibernate) to return a error, "Repeated column in mapping"

According to Hibernate discussions this problem can be fixed by marking the OneToMany as "update=false, insert=false" however this doesn't seem to be part of the 3.0 spec, yet?

Thanks.

[chasetec]

As far a some of what I've done:

Some is layout control, for instance: when viewing any topic my system(1024x768 resolution) renders the topic's center column too wide. The primary thing throwing the layout of(even on jboss.org) are the Quick Reply and the Jump to being too wide to be in the same row. Same with the little bb image headers when a user is logged in and using certain layouts.

I've fixed some of the security checks. If I remember correctly(late night coding) if you set a Forum's Reply and Post permissions to REG and then an annonymous use tried to do either of those things then stuff blew up.

The permission messages being displayed weren't correct when the security checks failed, now it's something like "I'm sorry but you must be at least an administrator to post messages in this forum" but before some TODO text was getting displayed and in one place a PHP sprintf was being displayed as an error message.


As far as what I want to do, I want to strip every half-way feature that's not going to be implemented before 1.1 release and fix all the security checking and moderation functionality. Things are happening like at the bottom of the page a message being displayed is "You can delete your posts in this forum" except unless I've made the person a mod then they can't! There seem to be security permission for features like attachments that aren't in the 1.1 branch. Basically I want the BB users to be able to view, modify, delete their posts; have many different mods managing forums with different permissions and have everyone be able to do everything at 1024x768(at minimum) with nothing being pushed off the screen except maybe in the \[code\] sections...

Isn't the "Disable BBCode in this post" suppossed to make the \[code\] statement's appears as typed and not rendered in any special way?

[julien1]

could you apply all the relevant fixes to HEAD branch as well ?

[chasetec]

"cooper" wrote:
could you apply all the relevant fixes to HEAD branch as well ?

Since HEAD has had it's own modification to the BB module I was probably going to wait till a couple more of the bugs in 1.1 got ironed out since the fixes will be have to be applied by hand. The diff just keeps scrolling and scrolling..... Easier just to do them all at once.

[julien1]

These fixes should have been applied to head first then backported to 1.1

Now you have to port them to head or they will be lost.

Maintaining several branch is not easy all the time, nevertheless it is the responsability of the developer to do it.

[chasetec]

"cooper" wrote:
These fixes should have been applied to head first then backported to 1.1

Well your lead Nukes guy so what you say goes but if we are aiming for a staple 1.1 branch ASAP and HEAD has a modified code base how can we catch all the bugs quickly without targeting 1.1 by itself? Maybe it's just a difference in thought process, after this round of updates I'll try to commit in the right order.

"cooper" wrote:

Now you have to port them to head or they will be lost.

Why??? If you could answer one of my unanswered questions in one of the other threads I think that would help me out.

"chasetec" wrote:

Is Nukes 1.1 going to be completely dropped the minute version 2 comes out? If so what's the point in HEAD? Are we going to be porting from HEAD or 1.1? Is 2 going to support the Nukes 1.1 modules or how much are things going to be different?

"cooper" wrote:

Maintaining several branch is not easy all the time, nevertheless it is the responsability of the developer to do it.

Hopefully there shouldn't be more then a couple days left of fixes to BB 1.1(given the amount of time I spend hacking at Nukes) and then I'll get those fixes in HEAD. Again, if the future I'll avoid initial committing to 1.1, where possible, I was just trying to make 1.1 stable without focusing on HEAD at the moment and I've always been under the impression that committing often as possible helps ease merge headaches and reduces duplicated work.