Can MainDeployerMBean call the deploy directly ?

[vickyk]

// Ok, now deploy the root deployable to finish the job

MainDeployerMBean md = (MainDeployerMBean)
MBeanProxyExt.create(MainDeployerMBean.class, mainDeployer, server);

try
{
md.deploy(config.getServerConfigURL() + config.getRootDeploymentFilename());
}
catch (IncompleteDeploymentException e) {
log.error("Root deployment has missing dependencies; continuing", e);
}

After going through the code of the MBeanProxyExt I found that this basically does the optimization based on method/attribute call on MBean. What I mean to say is that if the application calls the MBean setter/getter the same value could also be obtained from the corresponding attributes in the MBean . As per my understanding getting the attribute would be faster than getting the same data from the method call.
So I was wondering if calling the deploy method directly on the MainDeployerMBean is ok . I know this is just called once during the booting of the Jboss so would not significantly improve the booting.
Why I am suggesting to make a direct call to the MainDeployer is because the code will become more easy to understand ?
Does this make a sense?

Regards
Vicky

[dimitris]

Where is this code taken from? Can you provide more context?

[vickyk]

Please check the doStart() of the ServerImpl , here it goes
http://fisheye.jboss.com/viewrep/JBoss/jboss-system/src/main/org/jboss/system/server/ServerImpl.java?r=1.69

Regards
Vicky

[starksm64]

I'm not following your question then. The MBeanProxyExt is simply used to obtain a typesafe proxy on the jmx bean whose management interface is MainDeployerMBean. The standard jmx equivalent is to use the javax.management.MBeanServerInvocationHandler:

 ObjectName mainDeployer = ...;
 MBeanServer server = ...;
 MainDeployerMBean proxy = (MainDeployerMBean) MBeanServerInvocationHandler.newProxyInstance(
 server, mainDeployer, MainDeployerMBean.class, false);

[vickyk]

Scott,
Why can't we have

Object[] args = //URL
String[] sig = //void
server.invoke(mainDeloyer,"deploy",args,sig);

instead of this

MainDeployerMBean md = (MainDeployerMBean)
 MBeanProxyExt.create(MainDeployerMBean.class, mainDeployer, server);
 try
 {
 md.deploy(config.getServerConfigURL() + config.getRootDeploymentFilename());
 }
 catch (IncompleteDeploymentException e) {
 log.error("Root deployment has missing dependencies; continuing", e);
 }

This is what I am trying to say , as the code becomes more understandable .

Regards
Vicky

[starksm64]

The reason for using the typed proxy is that we believe that code is more readable/understandable when the proxy is used. Otherwise you are using a reflective type call every time an invocation is done, as opposed to a typed proxy.

[vickyk]

Yes, got it now!!!!
I think my understanding about the usage of the MBeanProxyExt was wrong, I initilly though that this was used for optimization as I could see the invocation to getter/setter handled by simply invoking the corresponding attributes.
Yes now I realize that this make code more readable/understandable than simply keeping the reflective calls in the code.