TODO: Improve management

[adrian.brock]

3766018

[spiritualmechanic]

Which properties do you think would be most useful. Would it be one big fat MBean, or several smaller ones?

[adrian.brock]

One example would be showing sql query time statistics from the jdbc rar.

I don't like FAT interfaces. You can make FAT interfaces from smaller ones.

[spiritualmechanic]

LOL I agree on the FAT interfaces. I just had to ask :D

Okay, so the sql stats would be a JDBC-specific MBean (probably under . I'll start thinking about this and suggesting adequate name(s) for it.

[spiritualmechanic]

package name

org.jboss.resource.adapter.jdbc.perf

or something like that?

[adrian.brock]

org.jboss.resource.adapter.jdbc.management

[spiritualmechanic]

Adrian,

I'm going to probably need to plug into the timer stuff to do monitoring of SQL executions. Should I look at the timer stuff first?

Is there timer stuff in jbosscx project? I searched but I don't see createTimer, so maybe it's in common. I'll do some more searching.

[adrian.brock]

Alex has already done this with a wrapper DataSource, although it should
really be in an interceptor.

http://www.jboss.org/wiki/Wiki.jsp?page=StatisticsCollector

[adrian.brock]

JIRA Task: http://jira.jboss.com/jira/browse/JBJCA-4

[vickyk]

I have been looking at this section

2) Better visibility of the Pool(s)

I am analyzing these features
1) wait times when request are waiting on an empty pool.
2) Idle time of unused connections.
3) Max waiting time to get the connection from the pool.

I see this code at InternalManagedConnection::getConnection(Subject ...,Cri ....)

long startWait = System.currentTimeMillis();
 try
 {
 connectionCounter.updateBlockTime(System.currentTimeMillis() - startWait);

 if (permits.attempt(poolParams.blockingTimeout))
 {
 //We have a permit to get a connection. Is there one in the pool already?

The connectionCounter.updateBlockTime(System.currentTimeMillis() - startWait); should be inside the permit.attempt(...) .