Spurious waring :-)

[adrian.brock]

13:09:34,478 WARN [JBossManagedConnectionPool] waring: prefill pool option was selected for pool that does not support this feature. Please verify your *-ds.xml configuration.
13:09:34,481 INFO [ConnectionFactoryBindingService] Bound ConnectionManager 'jboss.jca:name=JmsXA,service=ConnectionFactoryBinding' to JNDI name 'java:JmsXA'

1) Despite the typo, you don't need to put a redundant "warning"
in the text since it is handled by the log level.

2) You don't say which "-ds.xml" I have to check? This could at least
include the JBossManagedConnectionPool's ObjectName. Better
would be a reference to the jndi name, but it is quite hard for
it to get this.
There's a number of other messages in that class that
could benefit from this sort of context. :-)

3) I've checked my -ds.xml, using the second message and it doesn't
include config for prefilling :-)

jms/jms-ds.xml

 <!-- JMS XA Resource adapter, use this to get transacted JMS in beans -->
 <tx-connection-factory>
 <jndi-name>JmsXA</jndi-name>
 <xa-transaction/>
 <rar-name>jms-ra.rar</rar-name>
 <connection-definition>org.jboss.resource.adapter.jms.JmsConnectionFactory</connection-definition>
 <config-property name="SessionDefaultType" type="java.lang.String">javax.jms.Topic</config-property>
 <config-property name="JmsProviderAdapterJNDI" type="java.lang.String">java:/DefaultJMSProvider</config-property>
 <max-pool-size>20</max-pool-size>
 <security-domain-and-application>JmsXARealm</security-domain-and-application>
 </tx-connection-factory>

[weston.price]

We could the JNDI name as part of the XSLT. If it is this important, it might make sense to tie the attribute across all the MBeans that get generated at deployment time.

[weston.price]

And actually, quite a bit of the old code does the log.error("error: some message"); sutff. I will remove it where I see it and clean this stuff up.

[weston.price]

The other thing, on top of the prefill pool stuff I wanted to get into this release is the refactoring of the pool 'stuff' into it's own package and getting it out of the JBossManagedConnectionPool MBean. Static inner classes are fine, but this is ridiculous. I have this on a local build and was planning on checking it in later.

As always, I am going to assume silence is a 'go' ;-)

[weston.price]

And...IMHO, there is far too much of the inner class stuff in this code base for my comfort.