JCA AOP-MC Integration

[weston.price]

I am attempting to start aspectizing (as well as migrating our JCA services over to POJO land) services in JCA and I am using the JCA prototype from CVS as a template for creating/deploying aspects via aop-mc integration. I am not sure I am doing it right, or that the current aop-mc-int stuff can be integrated with what's in JBoss5 as I can't seem to get a TraceAspect to work. I believe the problems is in the AspectManager deployed in HEAD as this appears to be different that the one classes like

org.jboss.aop.microcontainer.beans.StackBinding

expect.

I have been down this route a couple of times before and had to restort to using aopc to get things to work. Any hints as to the root of my stupidity, or is this something that just hasn't been ported yet?

[weston.price]

Also, one of the things that has been holding back converting a lot of the JCA services to the MC is I don't want to lose the JMX management capabilties. I know that their is a JMXIntroduction that should allow POJO's to also be managed via JMX. Is this the way to do this at this point or will I have to refactor our stuff to have JMX as a shell that simply delegates to the POJO's for the real work?

[adrian.brock]

I believe the problems is in the AspectManager deployed in HEAD as this appears to be different that the one classes like

org.jboss.aop.microcontainer.beans.StackBinding

expect.

It used to work, so if it is broken then it is an issue for Kabir.

You shouldn't have to aopc since this stuff uses the proxy approach.
Most likely it is the proxy that has changed since there are no continous
integration tests.

[adrian.brock]

I know that their is a JMXIntroduction that should allow POJO's to also be managed via JMX. Is this the way to do this at this point

The JMXIntroduction is the way to go (although it is only currently a proof of concept).
JMX (management) is an aspect, you shouldn't be writing your own
framework/integration.

[kabirkhan]

Weston, can you please provide some code that reproduces the problem for me to look at?

[adrian.brock]

The prototypes are here:
http://fisheye.jboss.org/browse/JBoss/jboss-jca
http://fisheye.jboss.org/browse/JBoss/rars

I haven't looked at them for a while so I don't even know if they compile? :-)

They use some classes from aop-mc-int to configure AOP stacks.

[adrian.brock]

The jboss-jca stuff makes use of "hollow" proxies.

[kabirkhan]

The prototypes are here:
http://fisheye.jboss.org/browse/JBoss/jboss-jca
http://fisheye.jboss.org/browse/JBoss/rars

I have fixed these so they now work with all tests passing.

[weston.price]

I assume I can do the same thing against HEAD now right?

That is, the prototypes are simply that, prototypes; I really need to be able to use the same functionality against HEAD.

[weston.price]

Thanks for looking into it BTW.

[kabirkhan]

If you run into any problems point me to the code and I'll take a look :-)

[weston.price]

Cool. Thanks again.

[weston.price]

Problems abound :-)

It's still the same issue a bean definition such as

 <beanfactory name="TraceAdvice" class="org.jboss.resource.aspect.TraceAdvice"/>

 <bean name="TraceAspect" class="org.jboss.aop.microcontainer.beans.Aspect">
 <property name="advice"><inject bean="TraceAdvice"/></property>
 <property name="manager"><inject bean="AspectManager"/></property>
 </bean>

Fails with:

JCABinding
-> TraceAspect{Configured:**ERROR**}


*** CONTEXTS IN ERROR: Name -> Error

TraceAspect -> java.lang.IllegalArgumentException: Wrong arguments. setManager for target org.jboss.aop.microcontainer.beans.Aspect@56f691 expected=[org.jboss.aop.AspectManager] actual=[org.jboss.aop.deployers.AspectManagerJDK5]

Again, this is just a simple test to see if I can get something up and running. The ApectManger that the advice expects is obviously not the AspectManagerJDK5.

I looked at the changelog for the prototypes and nothing seemed to change. Can you give me an idea of what you modified?

[starksm64]

Try:

 <bean name="TraceAspect" class="org.jboss.aop.microcontainer.beans.Aspect">
 <property name="advice"><inject bean="TraceAdvice"/></property>
 <property name="manager"><inject bean="AspectManager" property="aspectManager"/></property>
 </bean>

[weston.price]

Excellent.

Thanks Scott, it's deploying.

Just for clarification, using the aop-mc-int module I should be able to deploy and use aspects without having to use the aopc compiler or enable anything in the AspectManager/Deployer correct? Or is there something I am missing? The reason I ask is that even after succesfully deploying, the aspect does nothing. I can see it deploying and the AspectManager at least knows about the definition (via JMX console) but it's not being invoked.