JBAS-5171 - New metadata - track-connection-by-tx

[adrian.brock]

http://jira.jboss.com/jira/browse/JBAS-5171

Can this be considered as proper?

Index: main/org/jboss/resource/metadata/mcf/ManagedConnectionFactoryDeploymentMetaData.java
===================================================================
--- main/org/jboss/resource/metadata/mcf/ManagedConnectionFactoryDeploymentMetaData.java (revision 69385)
+++ main/org/jboss/resource/metadata/mcf/ManagedConnectionFactoryDeploymentMetaData.java (working copy)
@@ -495,7 +495,7 @@
@ManagementProperty(name="track-connection-by-tx")
public Boolean getTrackConnectionByTransaction()
{
- return trackConnectionByTransaction;
+ return getLocalTransactions() || trackConnectionByTransaction;
}

Why don't you do what I did in the TxConnectionManager.
i.e. setTrackConnectionByTransaction(true) when setLocalTransactions(true)?

But anyway, we should really make transaction affinity the default
and force users to enable interleaving (see the JIRA issue and other
discussion in this forum).

JBoss5 is a good time to do that.
Most people don't understand what Interleaving is. That goes for both
users and resource adapter writers. :-)
So having it the default for XA just leads to FAQs - assuming that people
even understand what the problem is.

[aloubyansky]

I don't know whether it makes sense but I thought about the following sequence

mcf.setLocalTransactions(true);
mcf.setTrackConnectionByTransaction(false);

Alternatively, a check for localTransactions could be added to setTransactionConnectionByTransaction(value).

[dimitris]

I believe JBAS-5171 can be close now?

I created JBAS-5203 for Alexey to implement Adrian's suggestion, for CR1.

http://jira.jboss.com/jira/browse/JBAS-5203

[aloubyansky]

I've deprecated track-connection-by-tx and introduced interleaving element and managed attribute in the code. Also corrected the examples in connector/example-config.
The remaining is the schema connector/resources/schema/jboss-cf.xsd and the dtd. Both look inaccurate to me.
E.g. track-connection-by-tx in the schema is of boolean type and must always be present.
track-connection-by-tx is the dtd is declared as EMPTY but must always be present!
So, it seems like none of them was actually used (or used only when it didn't fail)?
I would fix the track-connection-by-tx in the current versions of schema and dtd then create another version of both w/o track-connection-by-tx but with interleaving. Does this sound right to everybody?

[jesper.pedersen]

The schema jboss-cf.xsd isn't being used currently, so dont spend any time on that -- it'll need to be synced if we go in that direction.

The track-connection-by-tx is currently mandatory for XA datasources (see Adrian's JBAS-5171 issue). The element is also used in the generic tx-connection-factory definition.

We need to create a new DTD for the element, remove the track-connection-by-tx and update all datasource examples to use the new DTD (something like jboss_ds_1_6.dtd).

This of course also means that the documentation should be updated to explain the setting - as listed by JBAS-5203.

[aloubyansky]

Could someone please correct the docs where needed?

I'll create a new DTD. None of the examples refer to a DTD, BTW.

[adrian.brock]

E.g. track-connection-by-tx in the schema is of boolean type and must always be present.
track-connection-by-tx is the dtd is declared as EMPTY but must always be present!
So, it seems like none of them was actually used (or used only when it didn't fail)?
I would fix the track-connection-by-tx in the current versions of schema and dtd then create another version of both w/o track-connection-by-tx but with interleaving. Does this sound right to everybody?

We don't validate against the dtd because we can't validate the embedded mbeans
https://jira.jboss.org/jira/browse/JBAS-460

I'd just leave

<track-connection-by-tx/>

in there as optional
(and ignored) and add the additional optional

<interleaving/>

If you're going to create a new version of the dtd then call it jboss-ds_5_0.dtd
this file has nothing to do with the JCA spec version.

[aloubyansky]

I'd think it makes sense to create a new version of the DTD since if I modify the existing one there could be a document that would be valid according to the DTD in JBoss 5 and invalid according to the same DTD version in the previous JBoss releases.

[jesper.pedersen]

Yeah, create a new version called jboss_ds_5_0.dtd like Adrian suggested.

That way users wont confuse it with something related to JCA 1.6 and other projects in the AS has used the same naming convention (jboss-service_5_0.dtd and so on).

[aloubyansky]

Done. About the docs, I've added notes to the following wiki pages
http://wiki.jboss.org/auth/wiki/JBossJCAPooling
http://wiki.jboss.org/auth/wiki/IHaveProblemsWithOracleXA
http://wiki.jboss.org/auth/wiki/ConfigJCACommon
http://wiki.jboss.org/auth/wiki/ConfigDataSources

If there are other places to mention this, please, do. Thanks.