JCA ConnectionManager SubjectFactory Injection

[anil.saldhana]

http://jira.jboss.com/jira/browse/JBAS-5067

The new changes happen in:
http://anonsvn.jboss.org/repos/jbossas/trunk/connector/src/main/org/jboss/resource/connectionmanager/BaseConnectionManager2.java
http://anonsvn.jboss.org/repos/jbossas/trunk/connector/src/main/org/jboss/resource/connectionmanager/BaseConnectionManager2MBean.java

Injection happens in:
http://anonsvn.jboss.org/repos/jbossas/trunk/connector/src/main/org/jboss/resource/deployers/builder/ConnectionManagerBuilder.java

 private static final String SUBJECT_FACTORY_NAME = "JBossSecuritySubjectFactory";
 private String subjectFactoryName = SUBJECT_FACTORY_NAME;

attribute = new ServiceAttributeMetaData();
 attribute.setName("SubjectFactory");
 ServiceInjectionValueMetaData injectionValue = new ServiceInjectionValueMetaData(subjectFactoryName);
 attribute.setValue(injectionValue);
 attributes.add(attribute);

The SubjectFactory interface from the security project looks:
http://anonsvn.jboss.org/repos/jbossas/projects/security/security-spi/tags/2.0.2.CR2/spi/src/main/org/jboss/security/SubjectFactory.java
The implementation of the SubjectFactory in AS5 is:
http://anonsvn.jboss.org/repos/jbossas/trunk/security/src/main/org/jboss/security/integration/JBossSecuritySubjectFactory.java


Questions:
- Should I retain the property of jaasSecurityMgrService in BaseConnectionManager2?

[anil.saldhana]

Additionally, the connection builder has the property for injection:

 public String getSecurityManagementName()
 {
 return subjectFactoryName;
 }
 public void setSecurityManagementName(String securityManagementName)
 {
 this.subjectFactoryName = securityManagementName;
 }

[anil.saldhana]

Copy/Paste error needs to be fixed.
http://jira.jboss.com/jira/browse/JBAS-5539