Recoverable registration implementation

[bill.burke]

This is in regards to:

http://jira.jboss.com/jira/browse/JBAS-1408

After looking at the JCA code a bunch, it seems that the best place for registering the recoverable might be in the RARDeployment class? After the MCF is fully created, the Recoverable would be registered with the Recovery manager based on all the recoverable properties.

Not sure this is the best place, but what I've found is that there is no Proxy in front of an MCF and that the implementation of an MCF is defined by the component plugin, correct? So it seems that RARDeployment is the best place to register the Recoverable.

[adrian.brock]

Its a bit confusing since there are two RARDeployment classes
(one that actually is the RARDeployment, the other for the MCF - ManagedConnectionFactory).

I assume you are talking about the one in
org.jboss.resource.connectionmanager
which is the one that turns the MCF into an MBean (by wrapping it).

Yes that is the correct place. It controls the MCF "lifecycle".

I believe the main change you need (beside the recovery registration)
is factoring out the security subject creation that is currently in BaseConnectionManager2?

OFF-TOPIC
It would be better named MCFDeployment or ConnectionDefinitionDeployment.
http://jira.jboss.com/jira/browse/JBAS-1425