pluggable Xid padding in JCA

[bill.burke]

This is in regards to:

http://jira.jboss.com/jira/browse/JBAS-1405

I was looking on how to implement this and it seems the approach would be to create a XAResource proxy whenever the TxConnectionManager.TxConnectionEventListener.getXAResource() is called. As long as the XAResource isn't a LocalTxResource.

Does this sound good?

[adrian.brock]

Yes, that was what we agreed.
Also, getting the XAResource during recover won't go through the connection manager.

Normal operation:
DataSource/ConnectionFactory -> ConnectionManager -> Pool -> MCF -> ManagedConnecton -> XAResource

However during recovery it doesn't use the pool/connection manager:
TM -> Recoverable/MCF -> ManagedConnection -> XAResource

I think you meant creating an XAResource wrapper rather than creating a proxy? :-)
Make sure to delegate toString() so we don't loose the ability to see the
real implementation in the logs.

[adrian.brock]

Having a getUnderlyingXAResource() may also be useful??

[bill.burke]

Also, I think a getRecoverable() may be useful in the future as well if one XAResource fails in commit we can retry it

[bill.burke]

Also, I think a getRecoverable() may be useful in the future as well if one XAResource fails in commit we can reconnect through the Recoverable and retry.