[edaugherty]

Yes, the headers do need to be addressed, so if you are intersted, it is yours to code.

[acoliver]

Not sure why yet but the recent sources seem to have broken SMTP AUTH. Eric mentioned that he thought the code was broken. It worked in my last checkout. Over the next week I hope to address this.

[acoliver]

Yes, note that the InternetHeaders object in JavaMail isn't serializable (DOH!)

[acoliver]

There is a more generic way to handle paths.... Take a look at the other descriptors. You should probably stick this under either server/xxx/certs or maybe server/xxx/conf/certs

[mk]

There is an error in SMTPProtocolInstance the following patch will fix it:

diff -r1.4 SMTPProtocolInstance.java
179c180
< if (!getProperty("SERVER_NAME").equals(toDomain)) {
---
> if (!getProperty(SERVER_NAME).equals(toDomain)) {

[edaugherty]

Patch applied.

[mk]

Ok, here are some patches that make mail-headers serializable.
The certificate is put into the header under the name 'X-Sender-Certificate'.
I also fixed a buf in AbstractProtocol.readCommand(). The former version failed when used from a Windows client, because a '\n' leaked into the InputStream (Windows terminates lines with '\r\n'). This caused the parsing of the headers to fail, because the first line was a blank one consisting of '\r'. Very nice bug, difficult to find (-:
Output of debugging info is differemt now, not one character/line.
The new Header class is copied from Sun, I just had to add a 'implements Serializable' on some places. Don't know why they did not do this themselves. I plan to write a condensed version in the future, but I want
to get this in, because a later merge could be difficult.
Do you have a version where all tests succeed? I had some difficulties with TestJMSMailListener and TestServer & TestSMPTProtocol.


Michael

[mk]

Anybody still alive? :-)

[acoliver]

Yes, sorry, I'm still on the road. Aren't you the same guy who did the TLS stuff? If so I think we should start thinking about getting you RW access...