4 Replies Latest reply on Jul 28, 2006 8:18 PM by acoliver

    MessageData getBoundary() bug?

    osterday

      Guys,

      I think this is a bug, but thought I'd post here before Jira.

      In the getBoundary() method in MessageData, I think the line:

      String[] header = getHeader("Content-Type").split("\\r\\n");


      Should be moved into the try/catch. If a message doesn't have a Content-Type, the method crashes.

      Not sure how the writeMessage in CmdRETR in the pop3 handlers would handle this, but I'm using similar code to read messages via a servlet and this issue just popped up for us.

      -Pat


        • 1. Re: MessageData getBoundary() bug?
          acoliver

          yes. That is a bug. Please post it in JIRA. Even better if you can add a patch. It ought return null if no boundary. Oddly it doesn't seem like I've had probelms in head sending and receiving messages.

          • 2. Re: MessageData getBoundary() bug?
            acoliver

            yes. That is a bug. Please post it in JIRA. Even better if you can add a patch. It ought return null if no boundary. Oddly it doesn't seem like I've had probelms in head sending and receiving plain text messages.

            • 3. Re: MessageData getBoundary() bug?
              osterday

              Andrew, I just posted the issue.

              Off topic I know, but how would/should patches be submitted? A diff? Or did I miss this info in a post?

              Thanks!

              • 4. Re: MessageData getBoundary() bug?
                acoliver

                AFTER a bug is created in JIRA. Then the "create attachment' thing shows up. Then from your jboss-mail dir do cvs diff -u > mypatch.foo

                New files should be zipped (tar.bz2 or tar.gz preferred, zip okay) relative to jboss-mail dir. Under no circumumstances should changed files be sumitted that way.

                Thats basically it. It is on the wiki but it needs to be updated to refer to jira.