Bug in getDeclaringClass in 3.0RC1

[hlovatt]

There is a bug in the getDeclaringClass method of CtClass when you try and get the declaring class of an anonymous inner class it throws FileNotFoundException. EG:

package examples.javassisttests.declaringclasses;
import javassist.*;
public class Test {
public static void main( final String[] notUsed ) throws NotFoundException {
new Object() {}; // annonymous inner class
final CtClass inner = ClassPool.getDefault().get( "examples.javassisttests.declaringclasses.Test$1" );
System.out.println( "Inner class = " + inner.getName() );
System.out.println( "Outer class (direct) = " + ClassPool.getDefault().get( "examples.javassisttests.declaringclasses.Test" ).getName() );
System.out.println( "Outer class (from inner) = " + inner.getDeclaringClass().getName() );
}
}

Produces:

Inner class = examples.javassisttests.declaringclasses.Test$1
Outer class (direct) = examples.javassisttests.declaringclasses.Test
javassist.NotFoundException
at javassist.ClassPool.get(ClassPool.java:295)
at javassist.CtClassType.getDeclaringClass(CtClassType.java:412)
at examples.javassisttests.declaringclasses.Test.main(Test.java:9)
Exception in thread "main"

[hlovatt]

I think I can answer my own question :)

In java.lang.Class the method getDeclaringClass returns null for an anonymous class because the Java Language Specification doesn't list anonymous classes as members of a class (but strangely does list named classes as members). I suspect therefore that CtClass's getDeclaringClass is mimicing this behaviour when it throws a NotFoundException for an anonymous class.

Sun have introduced in J5 a new method, getEnclosingClass, which works with anonymous and named classes and gives the outer class. Therefore, are there plans to add getEnclosingClass to Javassist?

[chiba]

That's a good idea. I'll implement it.

[chiba]

I have implemented getEnclosingClass().
The source is in CVS HEAD.

[hlovatt]

"chiba" wrote:
I have implemented getEnclosingClass().
The source is in CVS HEAD.

Thanks - I look forward to the next release

Keep up the good work

[chiba]

I have released 3.0!
Please enjoy.