Bug in compiler with null

[bill.burke]

I have been having trouble sometimes passing in null to a method call, particularly arrays. It is weird sometimes null just works, sometimes I have to typecast it, sometimes I have to declare a variable and pass the variable in. I don't have a testcase yet because sometimes it works, sometimes it doesn't.

i.e.

{
 Object[] args = null;
 foo.someMethod(args);

OR....

 foo.someMethod((Object[])null); // sometimes this doesn't work either
}
/code]

instead of just


{

 foo.someMethod(null);
}
/code]

[chiba]

I will check this.

[chiba]

I have just fixed this bug and commited
the source.
Thanks.

[bill.burke]

what was the problem? Just curious.

Thanks

[chiba]

The bug was in the code for comparing
argument types and parameter types.
If the parameter type(?) is null type, then
the code misinterpreted the descriptor of
the argument types.

[bill.burke]

The bug is still there. I took out my typecasting and just pass in null and it fails to generate code.

[chiba]

Really? What is the signature of foo.someMethod?

[bill.burke]

public Object invokeNew(Object[] args, int idx) throws Throwable

[chiba]

The following test code works fine on my machine. :<

ClassPool pool = ClassPool.getDefault(null);
CtClass cc = sloader.makeClass("test2.NullArgTest");
CtMethod m1 = CtNewMethod.make(
 "public Object foo(Object[] obj, int idx) throws Throwable {" +
 " return null; }", cc);
cc.addMethod(m1);
CtMethod m2 = CtNewMethod.make(
 "public void bar() { this.foo(null, 0); }", cc);
cc.addMethod(m2);
CtMethod m3 = CtNewMethod.make(
 "public void bar2() { this.foo((Object[])null, 0); }", cc);
cc.addMethod(m3);
cc.writeFile();