Du(Three)plicated proxy creation code

[alesj]

We have totally the same proxy creation code in three places:
- WrapperAdvice (managed)
- AbstractDeploymentContext (deployers)
- ProxyUtils (aop-int)

<T> T createProxy(T target, Class<T> interfaceClass)
 {
 if (target == null)
 return null;

 GeneratedAOPProxyFactory proxyFactory = new GeneratedAOPProxyFactory();
 AOPProxyFactoryParameters params = new AOPProxyFactoryParameters();
 params.setInterfaces(new Class[] { interfaceClass });
 params.setObjectAsSuperClass(true);
 params.setTarget(target);
 Object proxy = proxyFactory.createAdvisedProxy(params);
 if( log.isTraceEnabled() )
 log.trace("Created proxy: "+proxy.getClass()+"@"+System.identityHashCode(proxy)+" target: "+target.getClass());
 return interfaceClass.cast(proxy);
 }

Kabir, can we push this somehow in AOP (-jdk5)?
Or should we do a mc-common module / project?

[kabirkhan]

The whole idea behind the AOPProxyFactoryParameters was to avoid having methods in the GeneratedAOPProxyFactory for all the combinations of what might be passed in, but I can certainly add this one as a convenience method to GeneratedAOPProxyFactory.

[kabirkhan]

I've updated the aop snapshot so this method now lives in GeneratedAOPProxyFactory

[alesj]

Can it be made 'public static'?

[kabirkhan]

That was the intention, should be fixed now