DependencyBuilder chain

[alesj]

We should need some sort of a chain of DependencyBuilders.
Since currently there is only AbstractDependencyBuilder or AOPDependencyBuilder.

I added initial AnnotationDependecyBuilder (which isn't used at the moment) to check for Callback annotations.

How should we join all the DependencyBuilders?
btw: is this a good/proper way to handle annotations + dependencies?

I still need to add annotation check after instantiation state - for beanfactory beans.

[adrian.brock]

You need to speak to Kabir.

I will eventually get around to looking at/fixing this stuff to how I think it should work.
e.g. A lot of this stuff should apply to JMX as well (although I don't think we can
really integrate AOP with JMX without changing the JBossMX interceptor model?).

[alesj]

You need to speak to Kabir.

So Kabir :-), what do you think?

I will eventually get around to looking at/fixing this stuff to how I think it should work.
e.g. A lot of this stuff should apply to JMX as well (although I don't think we can
really integrate AOP with JMX without changing the JBossMX interceptor model?).

Which stuff - DependencyBuilder or CallbackItems?

Callbacks only depend on the 2 new interfaces we introduced - InvokeDispatchContext and AttributeDispatchContext - so they are not POJO specific. Maybe only getting the dependant class is more of a problem for MBeans.

[adrian.brock]

"alesj" wrote:

Which stuff - DependencyBuilder or CallbackItems?

Both and some others :-).

Do you know about the JMX integration in
jboss-head/jboss-system-jmx/src/main/org/jboss/system/microcontainer?

Ideally, we should be keeping this up-to-date with features in the MC.
Other examples include metadata and aliases.

[alesj]

Both and some others :-).

:-)
I've re-factored callbacks a bit from initial commit.

Do you know about the JMX integration in
jboss-head/jboss-system-jmx/src/main/org/jboss/system/microcontainer?

No. ;-)
'For an example of a simple facade., see the ServiceControllerContext'
- http://www.jboss.org/index.html?module=bb&op=viewtopic&t=103025

Ideally, we should be keeping this up-to-date with features in the MC.
Other examples include metadata and aliases.

Metadata?
Which parts do you have in mind - callbacks, ... ?

Ok, will add aliases for start, and see what I can do about callbacks and other stuff you have in mind.

[kabirkhan]

Can you explain the reasoning behind the chain of dependencies a bit? My knowledge pretty much stops at the AOP dependencies, which other dependencies are there?

[alesj]

Can you explain the reasoning behind the chain of dependencies a bit? My knowledge pretty much stops at the AOP dependencies, which other dependencies are there?

A seperate type of dependencies - AOP, injection, callback, <whatever-dependency>, ...
So that there is a list or chain of DependencyBuilders to execute.

I would like to plug in my @Callback/@Install/@Uninstall inspection.
So, is this the way to do it - AnnotationDependencyBuilder?

[kabirkhan]

I think that sounds reasonable.