4 Replies Latest reply on May 3, 2007 4:41 PM by alesj

    Javadoc fixes

      Ales, can you stop fixing my code while I'm still working on it. :-)
      Especailly when it is mainly javadoc fixes or non-semantic code changes.

      Some of the time you do this, I'm modifying the class as well, so I get merge problems
      which is really annoying. :-(

      Give it a few days to let the popcorn stop popping then fix it (if I haven't already
      spotted it myself by then anyway! :-)

        • 1. Re: Javadoc fixes
          alesj

          But if you spotted the same javadoc err, then it would not be a problem, while merging. :-)

          OK, understood.
          The thing is that I look at all the new things that come into MC, and try to at least fix the most obvious mistakes - being javadoc or some missing 'if' condition.
          Sorry if that broke some of your classloader code.
          But after few days I don't have all the info of new code - I could 'persuade' IDEA to keep that information, which I currently don't. Never really saw that as a problem since merging worked for me almost 99,99%.

          • 2. Re: Javadoc fixes

            You didn't break the code. We both made the same change, hence the merge problem.

            • 3. Re: Javadoc fixes

              I've pretty much finished with the base classloader code now
              (except for adding the Translator support).
              So you can play with all you like now. :-)

              • 4. Re: Javadoc fixes
                alesj

                 

                "adrian@jboss.org" wrote:

                So you can play with all you like now. :-)

                Hehe. Will do for sure.
                Pulling of some Dillons. ;-)