TypeInfo.newArrayInstance problems

[alesj]

I'm having problems instantiating char array via TypeInfo.newArrayInstance.
I get a CCE, when trying to cast char[] into Object[].
Is this expected? :-)
Or is there a workaround or should this be fixed?

[adrian.brock]

char is not an object.

To satisfy the cast to Object[] you'll need to "autobox" it to Character[]

[adrian.brock]

Or perhaps we should have a version like the reflect api
that returns an Object instead of Object[]?

char[] is an Object even if it isn't an Object[]

http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Array.html#newInstance(java.lang.Class,%20int)

[alesj]

char[] is an Object even if it isn't an Object[]

Yup, thought of that. ;-)
But this sucks, since then you don't know what to do when you have something like this:

 Object[] array;
 try
 {
 array = type.newArrayInstance(arrayValue.getLength());
 }
 catch (Throwable t)
 {
 throw new UndeclaredThrowableException(t);
 }
 for (int j = 0; j < array.length; j++)
 {
 Object element = arrayValue.getValue(i);
 if (element instanceof MetaValue)
 {
 TypeInfo elementType = configuration.getTypeInfo(element.getClass());
 element = unwrap((MetaValue)element, elementType);
 }
 array[j] = element;
 }

How to assign element to array if it were plain Object? :-)

[alesj]

Hmmm ... I was able to 'autobox' it.
Method is expecting char[] and I pushed in Character[], which is still not good.
I guess having plain Object is what we need ...

[adrian.brock]

For the plain Object you'd need to change your code to use something like the reflect api:

http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Array.html#getLength(java.lang.Object)
http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Array.html#get(java.lang.Object,%20int)

The latter method automatically autoboxes the primitives.

import java.lang.reflect.Array;

...

 Object array;
 try
 {
 array = type.newArrayInstanceObject(arrayValue.getLength());
 }
 catch (Throwable t)
 {
 throw new UndeclaredThrowableException(t);
 }
 for (int j = 0; j < Array.getLength(array); j++)
 {
 Object element = arrayValue.getValue(i);
 if (element instanceof MetaValue)
 {
 TypeInfo elementType = configuration.getTypeInfo(element.getClass());
 element = unwrap((MetaValue)element, elementType);
 }
 Array.set(array, j, element);
 }

[alesj]

http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Array.html#getLength(java.lang.Object)
http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Array.html#get(java.lang.Object,%20int)

The latter method automatically autoboxes the primitives.

Yup, was aware of this methods. :-)
Only questioned if we should 'hide' them in TypeInfo - only applicable for TypeInfo.isArray == true?
Or just ArrayInfo?

[adrian.brock]

"alesj" wrote:

http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Array.html#getLength(java.lang.Object)
http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Array.html#get(java.lang.Object,%20int)

The latter method automatically autoboxes the primitives.

Yup, was aware of this methods. :-)
Only questioned if we should 'hide' them in TypeInfo - only applicable for TypeInfo.isArray == true?
Or just ArrayInfo?

Why? I don't think this is something that javassist could optimize is it?
It's not like a Method or Field invocation
where you generate one class for each method you invoke.

[alesj]

Why? I don't think this is something that javassist could optimize is it?
It's not like a Method or Field invocation
where you generate one class for each method you invoke.

Understood and agreed. :-)
And the good thing is that the usage of this method is minimal - 1 existing case + my new one.

[alesj]

"alesj" wrote:
And the good thing is that the usage of this method is minimal - 1 existing case + my new one.

The tests disagree.
More then one failing. :-)
I'll try to fix them.

[alesj]

Got them all running.
Commiting the changes. :-)