This content has been marked as final.
Show 5 replies
-
1. Re: Finalize 2.0.0 api
alesj Nov 8, 2007 2:46 PM (in response to starksm64)"scott.stark@jboss.org" wrote:
http://jira.jboss.com/jira/browse/JBMICROCONT-216
As you could see, I closed this one, since it's a duplicate of http://jira.jboss.com/jira/browse/JBMICROCONT-215."scott.stark@jboss.org" wrote:
Let's do a review and get the old stuff out.
How do we spot the old stuff? :-) -
2. Re: Finalize 2.0.0 api
starksm64 Nov 8, 2007 2:56 PM (in response to starksm64)Ok. Just need to go through the spis, current issues to see if there are other out of date/should not exist spis.
-
3. Re: Finalize 2.0.0 api
alesj Nov 12, 2007 10:17 AM (in response to starksm64)Looking at the MainDeployer for JBMICROCONT-187 issue, I see that this
/** Deployments missing deployers */ private Map<String, DeploymentContext> missingDeployers = new ConcurrentHashMap<String, DeploymentContext>();
has no usage + no right place to populate it.
What was the usage of this?
Matching structural deployers?
Since with the real aspectized deployers, I don't see how you can determine if the deployment unit hasn't been 'touched', other than comparing the attachments snapshots before and after the deploy. -
4. Re: Finalize 2.0.0 api
alesj Nov 12, 2007 10:30 AM (in response to starksm64)"alesj" wrote:
What was the usage of this?
Matching structural deployers?
I guess it was this.
But then the Map's values shouldn't be DeploymentContexts, since you only get the DC ref if there is some matching StructureDeployer.
Changing it to Deployment. ;-) -
5. Re: Finalize 2.0.0 api
alesj Nov 12, 2007 10:39 AM (in response to starksm64)The reason this is here - in 'finalize api' - is that this triggers change to Deployers class.
* @param missingDeployer the deployments missing a deployer * @throws DeploymentException when some deployment is not complete */ - void checkComplete(Collection<DeploymentContext> errors, Collection<DeploymentContext> missingDeployer) throws DeploymentException; + void checkComplete(Collection<DeploymentContext> errors, Collection<Deployment> missingDeployer) throws DeploymentException;