-
30. Re: MC + JAXB (JBossXB Builder)
adrian.brock Mar 3, 2008 3:07 PM (in response to alesj)Also judging by what I've just seen in removing the schema initializer
for the plain javabean schema, I won't be convinced we are actually
testing things properly until there is only one mechanism being used.
http://jira.jboss.com/jira/browse/JBXB-123
Having a property as a subelement of constructor is just stupid, ;-)
But it can't be removed unless Scott tells me why he did it and where he used it? -
31. Re: MC + JAXB (JBossXB Builder)
adrian.brock Mar 3, 2008 3:10 PM (in response to alesj)On a related issue. I'm going to remove the IocTestDelegate.
This is really some JBossXB test support in the container project tests.
It's actually redundant since its just the JBossXBDelegate with a couple of extra
methods and its only used in the Spring tests.
I've already updated the JBossXBDelegate in JBossXB to have those methods
so if spring-int wants to import somebody else's test framework it should do
it directly from that project, i.e. JBossXB.
Since I'm working in JBossXB at the moment
http://jira.jboss.com/jira/browse/JBXB-121
breaking the circularity issue between container and jbossxb
let me know if you need something doing. -
32. Re: MC + JAXB (JBossXB Builder)
kabirkhan Mar 4, 2008 11:14 AM (in response to alesj)"adrian@jboss.org" wrote:
I also moved the GenericBeanFactoryMetaData2 into the spi and
called it GenericBeanFactoryMetaData.
This seems broken/untested. There are some tests for unmarshalling, which work, but if you try to actually install the resulting beans into MC you get problems like (I've already worked through some of these):java.lang.RuntimeException: java.lang.RuntimeException: java.lang.ClassCastException: org.jboss.beans.metadata.plugins.AbstractPropertyMetaD ata at org.jboss.aop.advice.AdviceFactory.create(AdviceFactory.java:110) at org.jboss.aop.Advisor.createInterceptorChain(Advisor.java:844) at org.jboss.aop.Advisor.pointcutResolved(Advisor.java:1200) at org.jboss.aop.MethodMatchInfo.applyBinding(MethodMatchInfo.java:143) at org.jboss.aop.MethodMatchInfo.overridePopulateBindings(MethodMatchInfo.java:134) at org.jboss.aop.MethodMatchInfo.populateBindings(MethodMatchInfo.java:83) at org.jboss.aop.Advisor.finalizeMethodChain(Advisor.java:928) at org.jboss.aop.ClassContainer.createInterceptorChains(ClassContainer.java:268) at org.jboss.aop.ClassContainer.rebuildInterceptors(ClassContainer.java:128) at org.jboss.aop.ClassContainer.initializeClassContainer(ClassContainer.java:64) at org.jboss.aop.proxy.container.ClassProxyContainer.initialise(ClassProxyContainer.java:173) at org.jboss.aop.proxy.container.ContainerCache.createContainer(ContainerCache.java:198) at org.jboss.aop.proxy.container.ContainerCache.createAndCacheContainer(ContainerCache.java:186) at org.jboss.aop.proxy.container.ContainerCache.initClassContainer(ContainerCache.java:159) at org.jboss.aop.proxy.container.ContainerCache.initialise(ContainerCache.java:92) at org.jboss.aop.proxy.container.ContainerCache.initialise(ContainerCache.java:72) at org.jboss.aop.microcontainer.integration.AOPDependencyBuilder.getDependencies(AOPDependencyBuilder.java:99) at org.jboss.kernel.plugins.dependency.DescribeAction.installActionInternal(DescribeAction.java:58) at org.jboss.kernel.plugins.dependency.InstallsAwareAction.installAction(InstallsAwareAction.java:54) at org.jboss.kernel.plugins.dependency.InstallsAwareAction.installAction(InstallsAwareAction.java:42) at org.jboss.dependency.plugins.action.SimpleControllerContextAction.simpleInstallAction(SimpleControllerContextAction.java:62) at org.jboss.dependency.plugins.action.AccessControllerContextAction.install(AccessControllerContextAction.java:71) at org.jboss.dependency.plugins.AbstractControllerContextActions.install(AbstractControllerContextActions.java:51) at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:327) at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1316) at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:734) at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:862) at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:784) at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:574) at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:398) at org.jboss.kernel.plugins.deployment.AbstractKernelDeployer.deployBean(AbstractKernelDeployer.java:336) at org.jboss.kernel.plugins.deployment.AbstractKernelDeployer.deployBeans(AbstractKernelDeployer.java:306) at org.jboss.kernel.plugins.deployment.AbstractKernelDeployer.deploy(AbstractKernelDeployer.java:130) at org.jboss.kernel.plugins.deployment.BasicKernelDeployer.deploy(BasicKernelDeployer.java:76) at org.jboss.kernel.plugins.deployment.xml.BasicXMLDeployer.deploy(BasicXMLDeployer.java:88) at org.jboss.test.aop.junit.JBossXBDeployer.deploy(JBossXBDeployer.java:133) at org.jboss.test.kernel.junit.MicrocontainerTestDelegate.deploy(MicrocontainerTestDelegate.java:289) at org.jboss.test.kernel.junit.MicrocontainerTestDelegate.deploy(MicrocontainerTestDelegate.java:433) at org.jboss.test.aop.junit.AOPMicrocontainerTestDelegate.deploy(AOPMicrocontainerTestDelegate.java:76) at org.jboss.test.kernel.junit.MicrocontainerTestDelegate.setUp(MicrocontainerTestDelegate.java:83) at org.jboss.test.aop.junit.AOPMicrocontainerTestDelegate.setUp(AOPMicrocontainerTestDelegate.java:60) at org.jboss.test.AbstractTestSetup.setUp(AbstractTestSetup.java:63) at junit.extensions.TestSetup$1.protect(TestSetup.java:18) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.extensions.TestSetup.run(TestSetup.java:23) at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196) Caused by: java.lang.RuntimeException: java.lang.ClassCastException: org.jboss.beans.metadata.plugins.AbstractPropertyMetaData at org.jboss.aop.microcontainer.beans.GenericBeanAspectFactory.doCreate(GenericBeanAspectFactory.java:96) at org.jboss.aop.microcontainer.beans.GenericBeanAspectFactory.createPerVM(GenericBeanAspectFactory.java:64) at org.jboss.aop.AspectManager.createPerVmAspect(AspectManager.java:1880) at org.jboss.aop.AspectManager.getPerVMAspect(AspectManager.java:1861) at org.jboss.aop.Domain.getPerVMAspect(Domain.java:770) at org.jboss.aop.Domain.getPerVMAspect(Domain.java:756) at org.jboss.aop.advice.PerVmAdvice.generateOptimized(PerVmAdvice.java:51) at org.jboss.aop.advice.AdviceFactory.create(AdviceFactory.java:106) ... 50 more Caused by: java.lang.ClassCastException: org.jboss.beans.metadata.plugins.AbstractPropertyMetaData at org.jboss.beans.metadata.plugins.factory.GenericBeanFactory.createBean(GenericBeanFactory.java:103) at org.jboss.aop.microcontainer.beans.GenericBeanAspectFactory.doCreate(GenericBeanAspectFactory.java:92) ... 57 more
I can fix these, but just wanted to make sure there aren't any tests somewhere that I am not aware of -
33. Re: MC + JAXB (JBossXB Builder)
kabirkhan Mar 4, 2008 11:26 AM (in response to alesj)In case I wasn't clear, it seems that the metadata created by GenericBeanFactoryMetaData.getBeans() is wrong.
-
34. Re: MC + JAXB (JBossXB Builder)
adrian.brock Mar 4, 2008 11:28 AM (in response to alesj)"kabir.khan@jboss.com" wrote:
"adrian@jboss.org" wrote:
I also moved the GenericBeanFactoryMetaData2 into the spi and
called it GenericBeanFactoryMetaData.
This seems broken/untested. There are some tests for unmarshalling, which work, but if you try to actually install the resulting beans into MC you get problems like (I've already worked through some of these):
...
I can fix these, but just wanted to make sure there aren't any tests somewhere that I am not aware of
No, like I said to Ales when he tried to close the JIRA issue,
there's a lot more to do than just testing the xml parsing. ;-)
It needs to actually use those objects in the runtime. -
35. Re: MC + JAXB (JBossXB Builder)
kabirkhan Mar 4, 2008 3:51 PM (in response to alesj)I have added a fix. I am relying on my aspect tests for my purposes