Context ClassLoader - Deployers

[adrian.brock]

This one is a bit more tricky as discussed before.

Currently, we don't set the context classloader when calling out to the deployers un/deploy.

The question is, what should the context classloader be?

There are two possible answers:
1) The deployment's classloader. i.e. DeploymentUnit.getClassLoader()
2) The deployer's classloader. i.e. the context classloader of whoever registered the deployer

The osgi style classloading rules will likely make the deployer classes
invisible from the application classloader, unless it explicitly imports them or uses
the old importAll rules (which is still the default).

Also the deployment's classloader isn't available until the CLASSLOADER stage.

So I'd propose that (2) is the correct context classloader. The deployer can
itself set the context classloader to the deployment classloader when required.
e.g. The EJB deployer does this.

[starksm64]

I agree on using the deployer class loader.

[adrian.brock]

Jira Issue http://jira.jboss.com/jira/browse/JBMICROCONT-231

[adrian.brock]

Jira Issue http://jira.jboss.com/jira/browse/JBMICROCONT-231

This has been done.

The only issue is whether we should clone the BeanMetaData before
modifying it's ClassLoaderMetaData.

For now I've chosen not to do that (Ales, did you test the cloning works properly?)
instead, the modified metadata is removed at undeployment to avoid memory leaks
on the classloader.

[adrian.brock]

Just to make it clear with this change and http://jira.jboss.com/jira/browse/JBMICROCONT-230

What will happen now by default is that a my-deployer-beans.xml
will get its own classloader (it's a deployment).

The deployer in that xml will install into the MainDeployer which will remember the
classloader (its the context classloader) for invoking un/deploy() of the deployer.

This is more intuitive than using the bootstrap classloader or some random
context classloader of an RMI/HTTP thread when invoking deployers.

[alesj]

For now I've chosen not to do that (Ales, did you test the cloning works properly?)

This should be done as part of http://jira.jboss.com/jira/browse/JBMICROCONT-28.
Where I'm still waiting for the introduction of UUID for the name, to get this fully implemented.
- http://www.jboss.org/index.html?module=bb&op=viewtopic&t=101320&start=20
So there is currently no cloning, hence no testing. :-)