Moving parsing to JBossXB.Builder/JAXB

[alesj]

I would like to finish with moving MC parsing to the new JBossXB.Builder.
In order to do that, lets first do a status check. :-)

Kabir, what's the status of AOP-MC-int and JAXB usage?
Since I've seen it moving in and out. :-)

Is the SchemaBindingResolver I've modified to use this new stuff in place?
Jumping in IDE to SingletonSchemaResolverFactory shows that we already use it:

 private SingletonSchemaResolverFactory()
 {
 // old initializer
 addSchema("urn:jboss:aop-beans:1.0", "org.jboss.aop.microcontainer.beans.xml.AOPBeansSchemaInitializer", Boolean.FALSE);
 addSchema("urn:jboss:spring-beans:2.0", "org.jboss.spring.deployment.xml.SpringSchemaInitializer", Boolean.FALSE);
 addSchema("urn:jboss:osgi-beans:1.0", "org.jboss.osgi.deployment.xml.OSGiSchemaInitializer", Boolean.FALSE);
 addSchema("urn:jboss:seam-components:1.0", "org.jboss.seam.ioc.microcontainer.xml.SeamSchemaInitializer", Boolean.FALSE);
 // new jaxb
 //addJaxbSchema("urn:jboss:aop-beans:1.0", "org.jboss.aop.microcontainer.beans.metadata.AOPDeployment");
 addJaxbSchema("urn:jboss:bean-deployer", "org.jboss.kernel.plugins.deployment.AbstractKernelDeployment10");
 addJaxbSchema("urn:jboss:bean-deployer:2.0", "org.jboss.kernel.plugins.deployment.AbstractKernelDeployment");
 addJaxbSchema("urn:jboss:javabean:1.0", "org.jboss.javabean.plugins.jaxb.JavaBean10");
 addJaxbSchema("urn:jboss:javabean:2.0", "org.jboss.javabean.plugins.jaxb.JavaBean20");
 addJaxbSchema("urn:jboss:policy:1.0", "org.jboss.beans.metadata.plugins.policy.AbstractPolicyMetaData");
 addJaxbSchema("urn:jboss:classloading:1.0", "org.jboss.classloading.spi.metadata.ClassLoadingMetaData10");
 addJaxbSchema("urn:jboss:classloader:1.0", " org.jboss.classloading.spi.vfs.metadata.VFSClassLoaderFactory10");
 }

Except for AOP.

We've already got people wandering:
- http://www.jboss.com/index.html?module=bb&op=viewtopic&t=132413
I've put David on hold until I validate that this is all working.
Probably the best test will be when I (re)move the old SchemaInitializer. :-)

I'll move the initializer code to spring-int.
Although predicted by Adrian that I'll eventually complain over this, I'll take my chances.

[kabirkhan]

Despite having a few things left I now have enough functionality in the JAXB variety to support what the AOPBeansSchemaInitializer does in AS 5.

The -beans.xml files using this will probably need to be modified a bit, the main thing is that aspects with properties

<deployment xmlns="urn:jboss:bean-deployer:2.0">
 <aop:aspect xmlns:aop="urn:jboss:aop-beans:1.0" class="org.jboss.test.microcontainer.beans.TestAspectWithDependency">
 <property name="dependency"><inject bean="Dependency"/></property>
 </aop:aspect>
</deployment>

will need to be rewritten to

<deployment xmlns="urn:jboss:bean-deployer:2.0">
 <aop:aspect xmlns:aop="urn:jboss:aop-beans:1.0" class="org.jboss.test.microcontainer.beans.TestAspectWithDependency">
 <aop:property name="dependency"><aop:inject bean="Dependency"/></aop:property>
 </aop:aspect>
</deployment>

or

<deployment xmlns="urn:jboss:bean-deployer:2.0">
 <aspect xmlns="urn:jboss:aop-beans:1.0" class="org.jboss.test.microcontainer.beans.TestAspectWithDependency">
 <property name="dependency"><aop:inject bean="Dependency"/></aop:property>
 </aspect>
</deployment>

I created a new branch so that I would not interfere with the release last week http://www.jboss.com/index.html?module=bb&op=viewtopic&t=132206
If you want me to do a merge to aop-mc-int trunk then let me know.

Before this will work I need releases of common-core, and jbossxb (you probably already knew the last one :-)

[alesj]

Before this will work I need releases of common-core, and jbossxb (you probably already knew the last one :-)

Sure, I know it by heart, specially the enum part. ;-)

OK, let me know when you're truly done.
I'll then finalize the work with removing the deprecated code/usage.

[adrian.brock]

Is this going to be finished for Friday's beta release?

So far I see two issues to make an MC Beta12 release.
http://jira.jboss.com/jira/browse/JBMICROCONT?report=com.atlassian.jira.plugin.system.project:roadmap-panel

None of the other projects have closed issues so there's no point doing releases for them.

P.S. Ales, do you want to do the release this Friday?

[alesj]

P.S. Ales, do you want to do the release this Friday?

To learn how to do a release of a project with more than one module (as opposed to VFS that I already did)?
Sure, why not.

[alesj]

Is this going to be finished for Friday's beta release?

It depends on how fast Kabir will resolve his aop+jaxb issues.
I already have locally removed and fixed/tested kernel module.

[kabirkhan]

I can put it in as soon as I get the mentioned releases. Ales, do you have permissions to release those projects?

[kabirkhan]

It's not "complete", but it covers what I had there for the AOPBeansSchemaInitializer variety and more

[alesj]

Ales, do you have permissions to release those projects?

I think so, but would rather leave that to Alexey or Adrian, who've done this previously + do most of the work on those projects.

[adrian.brock]

For JBossXB you need to ask Alex before you do it.

[aloubyansky]

I can release XB today. But for common I think you should ask Dimitris.

[alesj]

I can release XB today.

Kabir, make sure this gets uncommented:

 //addJaxbSchema("urn:jboss:aop-beans:1.0", "org.jboss.aop.microcontainer.beans.metadata.AOPDeployment");

;-)

What about this issue that I brought up:
- http://www.jboss.org/index.html?module=bb&op=viewtopic&t=132471
See my second post.
I think it should be weak on the value, on the class, removing entry when class goes away.

[aloubyansky]

Actually, the only change in XB would be update to the next common-core version. There have been not code changes (except the testcase I added for JBCOMMON-43).

[kabirkhan]

Good point Ales!

Alex, I cannot commit the switch, but basically in SingletonSchemaResolverFactory I want to

@@ -56,13 +56,13 @@
 */
 private SingletonSchemaResolverFactory()
 {
- // old initializer
- addSchema("urn:jboss:aop-beans:1.0", "org.jboss.aop.microcontainer.beans.xml.AOPBeansSchemaInitializer", Boolean.FALSE);
+ // old initializer
+ //addSchema("urn:jboss:aop-beans:1.0", "org.jboss.aop.microcontainer.beans.xml.AOPBeansSchemaInitializer", Boolean.FALSE);
 addSchema("urn:jboss:spring-beans:2.0", "org.jboss.spring.deployment.xml.SpringSchemaInitializer", Boolean.FALSE);
 addSchema("urn:jboss:osgi-beans:1.0", "org.jboss.osgi.deployment.xml.OSGiSchemaInitializer", Boolean.FALSE);
 addSchema("urn:jboss:seam-components:1.0", "org.jboss.seam.ioc.microcontainer.xml.SeamSchemaInitializer", Boolean.FALSE);
 // new jaxb
- //addJaxbSchema("urn:jboss:aop-beans:1.0", "org.jboss.aop.microcontainer.beans.metadata.AOPDeployment");
+ addJaxbSchema("urn:jboss:aop-beans:1.0", "org.jboss.aop.microcontainer.beans.metadata.AOPDeployment");
 addJaxbSchema("urn:jboss:bean-deployer", "org.jboss.kernel.plugins.deployment.AbstractKernelDeployment10");
 addJaxbSchema("urn:jboss:bean-deployer:2.0", "org.jboss.kernel.plugins.deployment.AbstractKernelDeployment");

http://jira.jboss.com/jira/browse/JBXB-136

[aloubyansky]

I've committed the fix. You should get the permission to commit to common and xb.