Root cause with iDependOn equal null

[alesj]

A bit related to this:
- http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4140958#4140958

In the case where iDependOn == null this is then used

Object iDependOn = item.getIDependOn();
 if (iDependOn == null)
 {
 dependency = "<UNKNOWN>";
 actualStateString = "** UNRESOLVED " + item.toHumanReadableString() + " **";
 }

Meaning (UNKNOWN) name is used for all dependencies that don't have iDependOn set.

But when we look for root cause (see IncompleteDeployments::calculateContextsError)

 Map<String, Set<MissingDependency>> contextsMissingDependencies = getContextsMissingDependencies();
 if (contextsMissingDependencies.isEmpty() == false)
 {
 for (Map.Entry<String, Set<MissingDependency>> entry : contextsMissingDependencies.entrySet())
 {
 for (MissingDependency dependency : entry.getValue())
 rootCauses.put(dependency.getDependency(), dependency.getActualState());
 }
 }

we use the name as key.
So all (UNKNOWN) would be flattened into single entry.

Should I add something like

 dependency = "<UNKNOWN " + GUID.asString() + ">";

?

[starksm64]

I believe it should just be <UNKNOWN + item.getName() +> so all dependencies on the unknown provider of name are seen as the same.

[alesj]

I believe it should just be <UNKNOWN + item.getName() +> so all dependencies on the unknown provider of name are seen as the same.

OK, I'll use that.
And then I'll group the values for the same key.
e.g.
mykey --> somedep
mykey --> otherdep
==> mykey -- > [somedep, otherdep]