ManagedObjectAttachmentsImpl::transientManagedObjects not tr

[alesj]

Looking at this

public class ManagedObjectAttachmentsImpl extends PredeterminedManagedObjectAttachmentsImpl implements ManagedObjectAttachments
{
 /** The serialVersionUID */
 private static final long serialVersionUID = -195530143173768763L;

 /** The transient managed objects */
 private MutableAttachments transientManagedObjects = AttachmentsFactory.createMutableAttachments();

 public MutableAttachments getTransientManagedObjects()
 {
 return transientManagedObjects;
 }

 public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException
 {
 super.readExternal(in);
 transientManagedObjects = (MutableAttachments) in.readObject();
 }

 /**
 * @serialData attachments
 * @param out the output
 * @throws IOException for any error
 */
 public void writeExternal(ObjectOutput out) throws IOException
 {
 super.writeExternal(out);
 out.writeObject(transientManagedObjects);
 }
}

what's transient about it, except for the name? :-)

[starksm64]

Its transient in that it does not affect that persistent view of the metadata as known by the profile service.

[adrian.brock]

No, its an error in the refactoring.

See transientAttachments here:
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/microcontainer/tags/OLD_DEPLOYERS/deployers/src/main/org/jboss/deployers/plugins/structure/AbstractDeploymentContext.java?revision=64008&view=markup

Transient attachments should not be serialzied unlike transient managed objects.

[alesj]

Transient attachments should not be serialzied unlike transient managed objects.

I'm confused now. :-)

The old code had transientManagedObjects transient.
Current code doesn't.
What should be then? :-)

[starksm64]

Both are logically transient and Adrian is saying they should be physically transient as well in terms of the default java serialization behavior. We used to have:

 /** The attachments */
 private transient Attachments transientAttachments = new AttachmentsImpl();

 /** The managed objects */
 private transient Attachments transientManagedObjects =
 GeneratedAOPProxyFactory.createProxy(new AttachmentsImpl(), Attachments.class);

Now transientAttachments exists as ManagedObjectsWithTransientAttachmentsImpl.transientAttachments and is marked transient, and transientManagedObjects exists as ManagedObjectAttachmentsImpl.transientManagedObjects and is not marked transient. Its also no longer an aop proxied instance.