No factoryClass does not use class attribute

[alesj]

Afaik we used to support this:

 <bean name="GetInstance" class="org.jboss.test.kernel.deployment.support.GetInstanceBean">
 <constructor factoryMethod="getInstance"/>
 </bean>

public class GetInstanceBean
{
 private static final GetInstanceBean instance = new GetInstanceBean("X");

 private GetInstanceBean(String x)
 {
 }

 public static GetInstanceBean getInstance()
 {
 return instance;
 }
}

Meaning when there was no factoryClass,
the bean's class attribute was used.

I guess this got lost with transition to jbossxb?

[adrian.brock]

"alesj" wrote:
Afaik we used to support this:

NOPE. You just imagined it. :-)
If there was no test for it in the testsuite, the feature didn't exist.

[alesj]

NOPE. You just imagined it. :-)

Could be, looking at old ConstructorHandler and BeanConstructorInterceptor. :-)

But this feels like a natural way of introducing factory method,
as I know I went that path a couple of times.

Should I add this behavior?
Or at least throw an exception that something is missing,
either factory or factoryClass?

[adrian.brock]

"alesj" wrote:

Should I add this behavior?
Or at least throw an exception that something is missing,
either factory or factoryClass?

You should do one or the other.
i.e. either support it or give a reasonable error message.

[alesj]

You should do one or the other.
i.e. either support it or give a reasonable error message.

I'll use the bean's class as default.