Re-deploying not-deployed deployment after adding new Deploy

[alesj]

This question popped here:
- http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4192930#4192930
I guess this would make sense.

But we must first fix the mechanism on how we resolve which deployments were really not deployed:
- http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191914#4191914

Then it should be just a matter of keeping track of not deployed deployments,
and triggering their re-deployment on new Deployer addition, plus some flag to enable/disable this.

[adrian.brock]

Well the real solution is to determine whether the new deployer applies
to ANY of the existing deployments and unwind them back to where
the new deployer has appeared.

Deployers disappearing would be pretty much the same
since you've got to allow the removed deployer to unwind whatever processing
it did to the deployment.

I didn't have time to do this logic when I wrote the deployers
but I remember putting some FIXMEs in the original version of the code.

[alesj]

Well the real solution is to determine whether the new deployer applies
to ANY of the existing deployments and unwind them back to where
the new deployer has appeared.

Deployers disappearing would be pretty much the same
since you've got to allow the removed deployer to unwind whatever processing
it did to the deployment.

I guess this is doable based on attachments?

e.g. adding some

boolean isApplied(DeployementUnit unit);

where we would in most cases be able to generically determine if we need unwind/rewind.

[alesj]

I didn't have time to do this logic when I wrote the deployers
but I remember putting some FIXMEs in the original version of the code.

This is the only FIXME in Deployers.

 // FIXME add method change logging levels to AbstractTestCase
 Logger.getLogger(FileSystemContext.class).setLevel(Level.INFO);

I guess I removed them in my re-factoring frenzy. :-)

I'll add a JIRA.
When should we target this? 2.0.1 or 2.2.0?

btw: is there a JIRA for your isDeployed todo?

[adrian.brock]

"alesj" wrote:

I'll add a JIRA.
When should we target this? 2.0.1 or 2.2.0?

Its a feature request, it gets done when it gets done.

btw: is there a JIRA for your isDeployed todo?

No, have we even decided how to do it?

[alesj]

Its a feature request, it gets done when it gets done.

- https://jira.jboss.org/jira/browse/JBDEPLOY-135