Adding metadata locations in real deployers

[alesj]

Is there a reason why we don't have
add, prepend, append, ... metadata locations api
on VFSDeploymentUnit as we do for classpath?

It might help to resolve some of the JBP issues:
- http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4203370#4203370

btw: I guess we should return unmodifiable wrappers around getClasspath
and getMetadataLocations on AbstractVFSDeploymentContext?

[starksm64]

I don't think the usage had come up yet. Relying on modifiable return values is not a good api.

[alesj]

I don't think the usage had come up yet.

It did now (see JBossPortal forum). :-)
And I already added the missing metadata locations methods - append, prepend, remove.

Relying on modifiable return values is not a good api.

You mean the append, prepend methods or direct collection ref returned?

I already changed getClassPath/MetaDataLocations to return unmodifiable collection.
I also deprecated VFSDeploymentUnit::setClassPath and added removeClassPath(VirtualFile... files) instead.
The setters should *not* exist on the user/client view.

[starksm64]

"alesj" wrote:

You mean the append, prepend methods or direct collection ref returned?

Direct collection ref return.