Making bean validaton part of kernel configuration

[alesj]

Looking at the code, I saw I did a crappy job of how we check for bean validators.
It just doesn't scale well by default. :-(

So, I did a little change, creating a KernelBeanValidator hanging from Kernel.
Hence it means it gets configured as part of Kernel.

It's a bit twisted by how it's done, in order to be back compatible.
You can trace the changes from KernelControllerContextAction::getBeanValidatorBridge.

[jaikiran]

"alesj" wrote:
Looking at the code, I saw I did a crappy job of how we check for bean validators.
It just doesn't scale well by default. :-(

Is such validation using BeanValidatorBridge being currently done? And when does this validation come into picture? I couldn't find any implementations of http://anonsvn.jboss.org/repos/jbossas/projects/microcontainer/branches/Branch_2_0/kernel/src/main/java/org/jboss/kernel/plugins/dependency/BeanValidatorBridge.java except an Mock one in the tests, hence this question. And what kind of validations are these? Looking at the method singatures, looks like it validates the "type" of the target object/parametes?

[alesj]

"jaikiran" wrote:

Is such validation using BeanValidatorBridge being currently done?
And what kind of validations are these? Looking at the method singatures, looks like it validates the "type" of the target object/parametes?

The bean validation is already used, if you installed some BeanValidatorBridge bean.
See old impl of KernelControllerContextAction.

This is meant to be a bridge between jsr303 (Emmanuel's bean validation) and our MC bean validation.
It validates different states of the bean, see the BVB interface and/or jsr303 for more details.

But the old way of looking for a validator was not very performance friendly.
Hence the change, which is done much better.

Can you check if it makes any difference?

[jaikiran]

"alesj" wrote:

Can you check if it makes any difference?

Sure. Let me just go through these changes. Will update this thread with the results.