This content has been marked as final.
Show 3 replies
-
1. Re: Wrong check in DeployersImpl.checkControllerContext()
alesj Jul 10, 2009 10:51 AM (in response to kabirkhan)Yeah, that looks wrong.
As why should item's whenRequired have anything to do with dependency's state.
I think it should beControllerState requiredState = item.getDependentState(); if (actualState == null || states.isBeforeState(actualState, requiredState))
But this breaks a few tests, hence I need to check if I'm really thinking straight. :-) -
2. Re: Wrong check in DeployersImpl.checkControllerContext()
alesj Jul 10, 2009 11:12 AM (in response to kabirkhan)"alesj" wrote:
But this breaks a few tests, hence I need to check if I'm really thinking straight. :-)
Actually they all pass, as I forgot to handle dependentState == null.
Once I did that, it's all fine.
I'll commit the fix, but let me know if I still got it wrong. -
3. Re: Wrong check in DeployersImpl.checkControllerContext()
alesj Jul 10, 2009 11:21 AM (in response to kabirkhan)"alesj" wrote:
I'll commit the fix, but let me know if I still got it wrong.
https://jira.jboss.org/jira/browse/JBDEPLOY-203