Circular and self dependencies

[thomas.diesler]

Folks,

I am looking at

https://jira.jboss.org/jira/browse/JBCL-24

which may be possible to fix in the classloading module alone. However I needed to make a trivial fix to the the Abstract controller in dependency

for (ControllerContext dependent : dependents)
{
 boolean selfDependency = (dependent == context);
 if (selfDependency == false && isBeforeState(dependent.getState(), whenRequired) == false)
 uninstallContext(dependent, whenRequired, trace);
}

This should not change the existing behaviour. All tests still pass

[alesj]

Where is this "fix", in AbstractController?

Even if some context depends on itself, you shouldn't simply ignore it - in general state machine view.
It should be simply reported as unresolved dependency as before, no special treatment required.

I guess with classloading it could be different.
But then it should be dealt in the classloading sub-project,
not at the abstract state machine level.

[thomas.diesler]

Where is this "fix", in AbstractController?

It is in dependency Branch_2_0

The code above prevents a stack overflow when the same context is a dependency of the context being uninstalled.

[adrian.brock]

"alesj" wrote:
Where is this "fix"

It looks like a fix to me. Before we've only had circular references on a different state
of itself. e.g. "this"

i.e. you can't inject "this" into a constructor ;-)

If the dependency is on the current state (whiich is what Thomas wants
for the circular references in the classloading), the previous uninstall code would loop.

[alesj]

It looks like a fix to me. Before we've only had circular references on a different state of itself. e.g. "this"

Kabir, can you also apply this to trunk please.

[kabirkhan]

"alesj" wrote:

It looks like a fix to me. Before we've only had circular references on a different state of itself. e.g. "this"

Kabir, can you also apply this to trunk please.

Done https://jira.jboss.org/jira/browse/JBKERNEL-53

Thomas, in future please create JIRA issues in JBKERNEL for your commits there :-)

[thomas.diesler]

Yes will do - thanks