-
1. Re: Functional unit tests in JBossCache codebase
belaban Jul 5, 2005 6:27 AM (in response to manik)No objections your honor
-
2. Re: Functional unit tests in JBossCache codebase
manik Jul 5, 2005 6:32 AM (in response to manik)The court ruling shall hold then, defendant Bela. :)
-
3. Re: Functional unit tests in JBossCache codebase
clebert.suconic Jul 5, 2005 10:08 AM (in response to manik)Please... make sure that the build.xml from the testsuite still working after your refactoring ;-)
-
4. Re: Functional unit tests in JBossCache codebase
ben.wang Jul 5, 2005 11:30 AM (in response to manik)That is true to reduce publicly accessible methods. But we want to make sure that the classes are not accidentally bundled into the source package. E.g., under aop, there are pojos like Payload and Person that are not test cases but helper classes instead.
-Ben -
5. Re: Functional unit tests in JBossCache codebase
manik Jul 8, 2005 1:52 AM (in response to manik)Ok, tests have been repackaged accordingly, it should allow for removal of unnecessary public methods in API classes which are only used for testing in future refactoring. Please sync up your tests dir.
Oh, and ignore all unit test failures in org.jboss.cache.optimistic ... :) This is still incomplete!
Do let me know if you have any probs with this new structure.
Cheers,
Manik
PS: Ben, I'll double-check the ant script, but I do believe nothing under the test dir is bundled into the src package. -
6. Re: Functional unit tests in JBossCache codebase
manik Jul 8, 2005 2:49 AM (in response to manik)I've also noticed that org.jboss.cache.transaction.DeadlockTest
(used to be org.jboss.cache.tests.transaction.DeadlockTest) still fails?
Is this a known issue, the failures are testConcurrentUpgrade and testMoreThanOneUpgrader? -
7. Re: Functional unit tests in JBossCache codebase
belaban Jul 8, 2005 3:25 AM (in response to manik)Yes, this is a known issue
-
8. Re: Functional unit tests in JBossCache codebase
ben.wang Jul 9, 2005 12:53 AM (in response to manik)Maink,
I don't expect we have accidentally bundled it into our package now. We just need to be aware of it.
-Ben