12 Replies Latest reply on Jan 6, 2009 9:43 AM by sdzmitrovich

VPE facelets ui:composition

mwr0707 Jan 4, 2009 9:50 AM

From the Facelets UI Tag Reference:

The UI Composition tag is a templating tag that wraps content to be included in another Facelet. Any content outside of the UI Composition tag will be ignored by the Facelets view handler. Any content inside of the UI Composition tag will be included when another Facelets page includes the page containing this UI Composition tag. See also ui:include.

In VPE, content outside of the ui:composition tag is getting included.
For example:

<ui:composition template="template.xhtml">
 <ui:define name="navigation">
 <ui:include src="menu.xhtml"/>
 </ui:define>
 </ui:composition>

The relevant parts of menu.xhtml are:

<body>
This text should be ignored

 <ui:composition>

 <h3>Contents table</h3>
 <hr/>
 </ui:composition>
</body>

At runtime "This text should be ignored" does not appear. It shows up in VPE.

1. Re: VPE facelets ui:composition

mwr0707 Jan 4, 2009 9:54 AM (in response to mwr0707)

Using 3.0.0.CR1, WTP 3.0.3
Actions
2. Re: VPE facelets ui:composition

akazakov Jan 4, 2009 5:08 PM (in response to mwr0707)

Looks like a bug. Please report it to https://jira.jboss.org/jira/browse/JBIDE
Actions
3. Re: VPE facelets ui:composition

sdzmitrovich Jan 5, 2009 3:45 AM (in response to mwr0707)

It must work correctly in web-project. But if you have ordinary java-project it works incorrectly.
Actions
4. Re: VPE facelets ui:composition

maxandersen Jan 5, 2009 3:57 AM (in response to mwr0707)

sdzmitrovich - why is there a difference in behavior for this dependent on type of project ?!
Actions
5. Re: VPE facelets ui:composition

sdzmitrovich Jan 5, 2009 5:20 AM (in response to mwr0707)

When visual page is being built it is tested if this page is facelet-page. For example "javax.faces.DEFAULT_SUFFIX" (in web.xml) is tested and if current page's extension doesn't equals it so this test is fault. But if project is not web-project this test is always fault ( because we know nothing about such project ).

Should we change this test? For example we can test only taglibs on page.
Actions
6. Re: VPE facelets ui:composition

maxandersen Jan 5, 2009 5:43 AM (in response to mwr0707)

wouldn't that be more correct ? i.e. test if facelet's are included in the page ?

Any downside to that ?
Actions
7. Re: VPE facelets ui:composition

mareshkau Jan 5, 2009 5:55 AM (in response to mwr0707)

Yes, I think test if facelt's uri included in the page will be more correct, than check web.xml.
Actions
8. Re: VPE facelets ui:composition

sdzmitrovich Jan 5, 2009 9:32 AM (in response to mwr0707)

I agree with Maxim. I think this solution is more flexible.
Actions
9. Re: VPE facelets ui:composition

mareshkau Jan 5, 2009 12:21 PM (in response to mwr0707)

FR was created for this https://jira.jboss.org/jira/browse/JBIDE-3482
Actions

10. Re: VPE facelets ui:composition

mwr0707 Jan 5, 2009 1:03 PM (in response to mwr0707)

Thanks for the followup!

The project that demonstrates the behavior was created with:
New->JSF Project
Environment: JSF 1.2 with Facelets
Template: FaceletsBlankWithoutLibs

I notice that the generated web.xml does include:

javax.faces.DEFAULT_SUFFIX

Working in Web Development perspective.

web.xml:

<?xml version="1.0"?>
<web-app version="2.5" xmlns="http://java.sun.com/xml/ns/javaee"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd">
 <description>Facelets StarterKit</description>
 <display-name>facelets1</display-name>
 <context-param>
 <param-name>javax.faces.DEFAULT_SUFFIX</param-name>
 <param-value>.xhtml</param-value>
 </context-param>
 <context-param>
 <param-name>facelets.REFRESH_PERIOD</param-name>
 <param-value>2</param-value>
 </context-param>
 <context-param>
 <param-name>facelets.DEVELOPMENT</param-name>
 <param-value>true</param-value>
 </context-param>
 <context-param>
 <param-name>javax.faces.STATE_SAVING_METHOD</param-name>
 <param-value>client</param-value>
 </context-param>
 <context-param>
 <param-name>com.sun.faces.validateXml</param-name>
 <param-value>true</param-value>
 </context-param>
 <context-param>
 <param-name>com.sun.faces.verifyObjects</param-name>
 <param-value>true</param-value>
 </context-param>
 <servlet>
 <servlet-name>Faces Servlet</servlet-name>
 <servlet-class>javax.faces.webapp.FacesServlet</servlet-class>
 <load-on-startup>1</load-on-startup>
 </servlet>
 <servlet-mapping>
 <servlet-name>Faces Servlet</servlet-name>
 <url-pattern>*.jsf</url-pattern>
 </servlet-mapping>
 <login-config>
 <auth-method>BASIC</auth-method>
 </login-config>
</web-app>

faces-config.xml:

<?xml version="1.0" encoding="UTF-8"?>
<faces-config version="1.2" xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xi="http://www.w3.org/2001/XInclude"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-facesconfig_1_2.xsd">
<application>
<view-handler>com.sun.facelets.FaceletViewHandler</view-handler>
<locale-config/>
</application>
<factory/>
<lifecycle/>
</faces-config>

11. Re: VPE facelets ui:composition

sdzmitrovich Jan 6, 2009 7:56 AM (in response to mwr0707)

If you create project with the help our wizards it must work correctly. I tested JBossTools-3.0.0.CR1-R200812191611-ALL-linux-gtk. This feature works correctly.
Actions
12. Re: VPE facelets ui:composition

sdzmitrovich Jan 6, 2009 9:43 AM (in response to mwr0707)

I mistook. It is really bug.
Actions

Go to original post