Annotations Persistence Unit JACC Integration

[bill.burke]

Wanted to know what you all should think the API should be for the security integration for entity manager. Currently it must be done in persistence.xml:

<persistence>
 <persistence-unit name="tempdb">
 <properties>
 <property name="hibernate.hbm2ddl.auto" value="create-drop"/>
 <property name="hibernate.jacc.allowed.org.jboss.ejb3.test.jacc.AllEntity" value="insert,update,delete,read"/>
 <property name="hibernate.jacc.allowed.org.jboss.ejb3.test.jacc.StarEntity" value="*"/>
 <property name="hibernate.jacc.allowed.org.jboss.ejb3.test.jacc.SomeEntity" value="insert,delete"/>

 <property name="hibernate.jacc.enabled" value="true"/>
 </properties>
 </persistence-unit>
</persistence>

My thinking is this:

public enum PersistenceAction {
 INSERT, DELETE, UPDATE, READ, ALL
}

@Target(TYPE) @Retention(RUNTIME)
public @interface PersistenceRolesAllowed {
 String[] roles();
 PersistenceAction[] actions() default ALL;
}

Usage:

@Entity
@PersistenceRolesAllowed(roles="everybody")
public class MyEntity


@Entity
@PersistenceRolesAllowed(roles="basic-user", actions={READ})
public class MyEntity{...}

[gavin.king]

Looks fine to me.

is "@PersistenceRolesAllowed" a bit or a mouthfull?

[arikkfir]

This sounds great - too bad it isn't part of the spec ;-)

But, as MS loves to say: there's always *.1 ;-)

[bill.burke]

It will be if we show that it is feasible. We almost *did* have this in the spec, but we ran out of time.