-
1. Re: JBossDDObjectFactory use of SystemPropertiesService
starksm64 Mar 22, 2007 6:45 PM (in response to brian.stansberry)You would need to ask whoever added the call to SystemPropertiesService, but I can't see why this coupling should exist. The StringPropertyReplacer is what should be used.
I added support to the 2.0.x jbossxb ObjectModelFactory base so that all ObjectModelFactory instance did property substitution via StringPropertyReplacer unless they indicated otherwise. This could be backported to the 1.0.x jbossxb as well. -
2. Re: JBossDDObjectFactory use of SystemPropertiesService
bdecoste Mar 22, 2007 7:01 PM (in response to brian.stansberry)StringPropertiesService gives the user the ability to set params all in one place. EJB2.x provided this capability and we have several customers who requested it in EJB3. The properties are configured in the StringPropertiesService
What are you seeing fail or think will fail? The warning you are seeing is just saying that a ${...} pattern was found and the StringPropertiesService is not running. -
3. Re: JBossDDObjectFactory use of SystemPropertiesService
starksm64 Mar 22, 2007 7:29 PM (in response to brian.stansberry)Which is why this should not be used from the object factories. StringPropertiesService is an option means to set properties via xml. The StringPropertyReplacer is still what should be used to retrieve properties as it works regardless of what the source was.
-
4. Re: JBossDDObjectFactory use of SystemPropertiesService
bdecoste Mar 22, 2007 7:39 PM (in response to brian.stansberry)You've lost me. StringPropertyReplacer is just a utility to parse for ${...} and replace given a mapping. There is no source for the mapping. I could replace the getValue(String name, String value) logic in the object factory with StringPropertyReplacer, but that can't be what you are suggesting.
We need a source for the mapping. StringPropertiesService is the source. -
5. Re: JBossDDObjectFactory use of SystemPropertiesService
starksm64 Mar 22, 2007 7:44 PM (in response to brian.stansberry)System.getProperties() is the source. StringPropertiesService pushes onto the System properties.
-
6. Re: JBossDDObjectFactory use of SystemPropertiesService
bdecoste Mar 22, 2007 7:53 PM (in response to brian.stansberry)OK, I'll make the change.
-
7. Re: JBossDDObjectFactory use of SystemPropertiesService
wolfc Mar 23, 2007 5:23 PM (in response to brian.stansberry)The backport to jbossxb (now 1.0.0-CR9-brew) is needed for EJB3 plugin (/ AS 4.2).
I've got a module jboss-metamodel-dd in ejb3 which currently is the mavenized version. It still needs a proper place and proper dependencies.
Note that JBossWS stuff is not working there.