JBAS-4489 - Suspending Incomplete BMT transactions

[adrian.brock]

http://jira.jboss.com/jira/browse/JBAS-4489

I see you were already suspending incomplete transactions,
which means you had already seen and resolved the problem.

I think there is still an issue that you should be throwing an exception
for the incomplete transaction, otherwise the caller isn't going to know it failed!

The real problem is that my test is broken, it doesn't assert that it actually
got the expected exception. It should be something like:

 public void testTxTimeout()
 {
+ boolean gotException = true;
 BMTCleanUp remote = (BMTCleanUp) sessionCtx.getEJBObject();
 try
 {
 remote.doTimeout();
 }
 catch (EJBException expected)
 {
 // expected
 expected.printStackTrace();
+ gotException = true;
 }
+ if (gotException == false)
+ throw new EJBException("Did not get expected exception for incomplete transaction");
 checkTransaction();
 remote.doNormal();
 }

[wolfc]

The exception throwing should work as well. I'll modify the test case.
I'll also modify the message to point to the EJB3 spec instead of EJB1.1.

[wolfc]

Hmm, after a timeout the status is set to ROLLEDBACK. I can't see whether this due to timeout or ut.rollback().

[andy.miller]

Carlo, as I understand it from the initial thread on this topic, when the transaction times out, JBoss Transactions will set the transaction status to ROLLEDBACK, so what you are seeing is the correct behavior for the test case.

[wolfc]

But that means no exception is thrown.
Ah wait, now I see.

boolean gotException = true;

Does this mean I can Wolf Adrian? :-)

[andy.miller]

Wolf Adrian at you own risk ;-)

[bdecoste]

I'd Burke him to be safe.