Plug-able default JNDI binding policy

[bdecoste]

This is something we've discussed in the past, but it's come up again. I propose that we create a plug-able default jbndi policy. It's becoming clear that no matter what we choose for a default policy, somebody doesn't like it. SEAM is having problems with embedded in multiple wars and would like the default policy to be warName/bean/Name.

I don't think it would be that much work - maybe a day or 2. The jndi code is fairly isolated now. Here's what we would need to do

- create the policy api. Probably just 1 method like

String getJndiBinding(String deploymentName, String beanName, boolean
isLocal, isHome);

- create an impl for the current policy
- create an annotation like @JndiPolicy for setting the policy impl
- modify ejb3-interceptors-aop.xml to default the default policy
- modify the jboss.xml schema and code to add the new annotation

Thoughts?

[alrubinger]

+1.

Current implementation is dependent on packaging, which, while ensuring namespace-based unique values, immediately breaks all applications once JAR names change, are placed into an EAR, etc.

Bean providers must currently override default names using their own homebaked solution; I'd heavily made use of LocalBinding/RemoteBinding on every EJB just for this purpose. Pluggable policy would address this in one fell swoop.

S,
ALR

[alrubinger]

Would also make sense to determine what properties in a deployment might be interesting to a developer implementing a binding strategy, and pass this in:

String getJndiName(SomeNewEjb3DeploymentTO)

..giving the TO instance members:

* deploymentName
* ejbName
* isLocal
* isHome
* isService
* isStateful
* deploymentType
* beanType

...anything else?

S,
ALR

[gavin.king]

Not sure if an annotation is really useful. Makes most sense in jboss.xml or jboss-app.xml.

[bdecoste]

We'll have both - an annotation and a place in jboss.xml. All of out metadata is available via an annotation and xml.

[alrubinger]

An entry in jboss-app.xml would also allow us to define a policy for all modules in the EAR; wouldn't require explicit definition on the part of the bean provider for each. Sounds very beneficial.

S,
ALR

[alrubinger]

http://jira.jboss.com/jira/browse/EJBTHREE-1101

I've added a default pluggable binding strategy that mirrors the legacy implementation.

Still TODO: Allow definition in jboss.xml, jboss-app.xml (optional for now).

API in org.jboss.ejb3.jndipolicy.DefaultJndiBindingPolicy

S,
ALR

[wolfc]

Create a new artifact in projects/ejb3 so we can import one component into both 4.2 and 5.

For the xml I would to see an expression in the likes of: ${earName}/${deploymentName}/${beanName}/${interfaceType}

I don't want a requirement to create new classes when configuring xml stuff.

[starksm64]

Alexey has added a String class name to JBossEnterpriseBeanMetaData. The DefaultJndiBindingPolicy/EjbDeploymentSummary interfaces could be part of metadata so that one can load the policy and use it in the determineJndiName() methods so that there is one method to call to obtain an ejb's jndi name.

[starksm64]

Related to this is how the ProxyDeployer determines the remote interface binding jndi name. If I need to determine the target jndi name at reference resolution time, this needs to be set earlier.

[rodrigo.uchoa]

Can this be done in JBoss 5.1.0? I would like a way to change the default naming behavior for all EJB jndi names, instead of using the LocalBinding/RemoteBinding annotation in code. Something like a external configuration done on jboss itself, not hard coded inside the applcation code.