2 Replies Latest reply on Apr 16, 2008 12:17 PM by starksm64

    EJBTHREE-1291, deployment resolver unification

    starksm64

      Related to the EJBTHREE-1291 work, there is duplicate logic going on for resolving component endpoints that is spread out across the DeploymentScope
      EjbModuleEjbResolver, EjbModulePersistenceUnitResolver, MessageDestinationResolver and injection handler code.

      I'm proposing either using the generalized DeploymentEndpointResolver spi in integration:
      https://svn.jboss.org/repos/jbossas/projects/integration/trunk/jboss-deployment-spi/src/main/java/org/jboss/deployment/spi/

      or at least mirroring this interface in DeploymentScope so that it can be properly implemented inside of jbossas. The EjbModuleEjbResolver, EjbModulePersistenceUnitResolver, MessageDestinationResolver code would be replaced based on this and the injection handler code should do no resolution as the metadata it receives has to have been resolved with the resolvedJndiName set.

        • 1. Re: EJBTHREE-1291, deployment resolver unification
          wolfc

          Let's first throw IllegalStateException if no jndi name is set and see where regression is spotted.

          • 2. Re: EJBTHREE-1291, deployment resolver unification
            starksm64

            As a first step I removed the EjbModuleEjbResolver from the Ejb3Deployment and added the equivalent functionality to the DeploymentScope interface for which jbossas provides the impl.

            The impl either relies on the endpoint map produced by the MappedReferenceMetaDataResolverDeployer if enabled, or the EjbModuleEjbResolver which has been copied into jbossas under ejb3 with the package org.jboss.ejb3.deployers.tmp if the ReferenceMetaDataResolverDeployer is enabled (its still the default).