Serializable DeploymentSummary

[emuckenhuber]

by chance i saw this failure in the deployers test in the AS testsuite, when getting the deploymentUnit in the test - for example in o.j.t.deployers.ejb.test.EJBDeploymentUnitTestCase.testEJBDeployment

java.io.NotSerializableException: org.jboss.metadata.ejb.jboss.jndipolicy.spi.DeploymentSummary
 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1081)
 at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
 at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
 at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
 at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:302)
 at java.util.concurrent.ConcurrentHashMap.writeObject(ConcurrentHashMap.java:1380)
 at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:917)
 at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1339)
 at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
 at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
 at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
 at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
 at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:302)
 at org.jboss.deployers.plugins.attachments.AttachmentsImpl.writeExternal(AttachmentsImpl.java:145)

Does the DeploymentSummary need to be Serializable or can we just define it as transient ?

Emanuel

[starksm64]

It needs to be Serializable as most metadata does.

[alrubinger]

Emmanuel, this is probably a leftover detail from my inital mock implementation; apologies.

Yes, this was intended to be a Serializable view describing the deployment in terms that a Binding Policy might be interested to generate a default base.

S,
ALR